IA2 role is not correct for input type attribute in button and checkbox state with menu as parent

Source/core/accessibility/AXNodeObject.cpp

Index: Source/core/accessibility/AXNodeObject.cpp
diff --git a/Source/core/accessibility/AXNodeObject.cpp b/Source/core/accessibility/AXNodeObject.cpp
index 34c1230cd4d494dc4864058f43f7edffccbb22fe..9fb2da7454613685948a588d214d9e598bf721c6 100644
--- a/Source/core/accessibility/AXNodeObject.cpp
+++ b/Source/core/accessibility/AXNodeObject.cpp
@@ -202,8 +202,16 @@ AccessibilityRole AXNodeObject::determineAccessibilityRole()
     if (isHTMLInputElement(*node())) {
         HTMLInputElement& input = toHTMLInputElement(*node());
         const AtomicString& type = input.type();
-        if (type == InputTypeNames::checkbox)
+        if (type == InputTypeNames::button) {
+            if (node()->parentNode() && isHTMLMenuElement(node()->parentNode()))
+                return MenuItemRole;
+            return buttonRoleType();
+        }
+        if (type == InputTypeNames::checkbox) {
+            if (node()->parentNode() && isHTMLMenuElement(node()->parentNode()))
+                return MenuItemRole;

[dmazzoni, 2014/09/26 15:59:20]

This doesn't look right.

Why not create a new role CheckboxMenuItem?

Then we can map that to the appropriate role depending on the platform.

             return CheckBoxRole;
+        }
         if (type == InputTypeNames::radio)
             return RadioButtonRole;
         if (input.isTextButton())