Source/modules/webdatabase/DatabaseContext.cpp - Issue 589363002: Oilpan: DatabaseThread::m_thread should not get destructed during sweeping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webdatabase/DatabaseContext.cpp

Issue 589363002: Oilpan: DatabaseThread::m_thread should not get destructed during sweeping (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/webdatabase/DatabaseContext.cpp

diff --git a/Source/modules/webdatabase/DatabaseContext.cpp b/Source/modules/webdatabase/DatabaseContext.cpp

index 456087abd8cf1966d3cf3df6aa1164b1affae824..3e967700ac3fc79586b2b4c6f8cc2e29457d3f04 100644

--- a/Source/modules/webdatabase/DatabaseContext.cpp

+++ b/Source/modules/webdatabase/DatabaseContext.cpp

@@ -178,10 +178,9 @@ void DatabaseContext::stopDatabases()

// DatabaseThread.

if (m_databaseThread && !m_hasRequestedTermination) {

- TaskSynchronizer sync;

- m_databaseThread->requestTermination(&sync);

+ // This blocks until the database thread finishes processing the cleanup task.

+ m_databaseThread->terminate();

m_hasRequestedTermination = true;

- sync.waitForTaskCompletion();

}