Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: Source/modules/webdatabase/DatabaseContext.cpp

Issue 589363002: Oilpan: DatabaseThread::m_thread should not get destructed during sweeping (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/webdatabase/DatabaseThread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webdatabase/DatabaseContext.cpp
diff --git a/Source/modules/webdatabase/DatabaseContext.cpp b/Source/modules/webdatabase/DatabaseContext.cpp
index b327f4c395b29d23963d714de3ca851644af63f4..2cfd3e48e5c024cde2c47001eb351a7af864b61f 100644
--- a/Source/modules/webdatabase/DatabaseContext.cpp
+++ b/Source/modules/webdatabase/DatabaseContext.cpp
@@ -183,10 +183,9 @@ void DatabaseContext::stopDatabases()
// DatabaseThread.
if (databaseThreadAvailable()) {
- TaskSynchronizer sync;
- m_databaseThread->requestTermination(&sync);
m_hasRequestedTermination = true;
- sync.waitForTaskCompletion();
+ // This blocks until the database thread finishes the cleanup task.
+ m_databaseThread->terminate();
}
}
« no previous file with comments | « no previous file | Source/modules/webdatabase/DatabaseThread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698