Oilpan: blink_heap_unittests: MapWithCustomWeaknessHandling and MapWithCustomWeaknessHandling have …

Oilpan: blink_heap_unittests: MapWithCustomWeaknessHandling and MapWithCustomWeaknessHandling have some leaks

1. we need a collectAllGarbage() at the end of test to do some clearing work.

R=ager@chromium.org, oilpan-reviews@chromium.org
BUG=416765
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182480

[haraken, 2014-09-23 07:29:15]

Does this mean that collectAllGarbage is called at the end of each test?

If it won't slow down unit tests, I'm completely fine with the CL.

[Mads Ager (chromium), 2014-09-23 07:50:40]

LGTM

Yes, this means that we call collectAllGarbage for each test. On my machine I
can't measure the difference when running the debug mode tests. The change that
I did yesterday means that we get a fresh heap setup per test. That probably
means that we can remove some of the clearOutOldGarbage calls in the beginning
of tests.

[Daniel Chow, 2014-09-23 07:51:41]

On 2014/09/23 07:29:15, haraken wrote:
> Does this mean that collectAllGarbage is called at the end of each test?
> 
> If it won't slow down unit tests, I'm completely fine with the CL.

yes, it is called at the end of each test.
and, I just have a test for the time to run all of blink_heap_unittests on
release vesion on my 64-bit liniux system. 
The gap between them was rarely a few milliseconds. (before is 0.407912s, after
is 0.408170s)

[haraken, 2014-09-23 07:53:13]

On 2014/09/23 07:51:41, Daniel Chow wrote:
> On 2014/09/23 07:29:15, haraken wrote:
> > Does this mean that collectAllGarbage is called at the end of each test?
> > 
> > If it won't slow down unit tests, I'm completely fine with the CL.
> 
> yes, it is called at the end of each test.
> and, I just have a test for the time to run all of blink_heap_unittests on
> release vesion on my 64-bit liniux system. 
> The gap between them was rarely a few milliseconds. (before is 0.407912s,
after
> is 0.408170s)

Thanks, LGTM!

[Daniel Chow, 2014-09-23 07:55:44]

The CQ bit was checked by zhishun.zhou@samsung.com

[commit-bot: I haz the power, 2014-09-23 07:56:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/589343002/1

[commit-bot: I haz the power, 2014-09-23 09:34:59]

Committed patchset #1 (id:1) as 182480