Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 58933005: Override drawRRect in fake SkBitmapDevices. (Closed)

Created:
7 years, 1 month ago by scroggo
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Override drawRRect in fake SkBitmapDevices. Recent changes to SkBitmapDevice modified ::drawRRect() to take an optimized drawing case (currently hidden behind a flag). Some subclasses of SkBitmapDevice were depending on the old behavior of calling ::drawPath(). Since they do not draw, attempting to take the drawing path can cause problems. For these subclasses, call drawPath in the subclass. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234717

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M skia/ext/analysis_canvas.h View 1 chunk +3 lines, -0 lines 0 comments Download
M skia/ext/analysis_canvas.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M skia/ext/vector_platform_device_emf_win.h View 1 chunk +2 lines, -0 lines 0 comments Download
M skia/ext/vector_platform_device_emf_win.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
scroggo
7 years, 1 month ago (2013-11-12 20:24:30 UTC) #1
robertphillips
lgtm
7 years, 1 month ago (2013-11-12 20:49:24 UTC) #2
reed1
lgtm
7 years, 1 month ago (2013-11-12 21:25:18 UTC) #3
scroggo
Florin, can you take a look for committer approval?
7 years, 1 month ago (2013-11-12 21:26:43 UTC) #4
f(malita)
lgtm
7 years, 1 month ago (2013-11-12 21:28:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scroggo@google.com/58933005/1
7 years, 1 month ago (2013-11-12 21:52:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scroggo@google.com/58933005/1
7 years, 1 month ago (2013-11-12 23:33:34 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-13 00:58:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scroggo@google.com/58933005/1
7 years, 1 month ago (2013-11-13 01:20:22 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 02:53:47 UTC) #10
Message was sent while issue was closed.
Change committed as 234717

Powered by Google App Engine
This is Rietveld 408576698