Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 589313002: X87: Further improve deopt reason output (Closed)

Created:
6 years, 3 months ago by chunyang.dai
Modified:
6 years, 3 months ago
Reviewers:
Weiliang, Sven Panne
CC:
v8-dev, danno
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

X87: Further improve deopt reason output port r24123. R24123 does not cover all required code change in X87. original commit message: Further improve deopt reason output. * Make the detailed deopt reason mandatory on x64, other platforms will follow in separate CLs. * Extracted and improved jump table entry sharing logic: When --trace-deopt is on, we get separate entries for different deopt reasons. This enables us to distinguish the several reasons single instructions can have. * Don't emit superfluous jump table comments: The bailout ID is still visible, and the jump table entry number is not interesting (but easy to determine if really needed). * Unify the internal name of the jump table member across platforms. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M src/x87/lithium-codegen-x87.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
chunyang.dai
WL & Sven. PTAL. thanks
6 years, 3 months ago (2014-09-23 02:39:08 UTC) #2
Weiliang
lgtm
6 years, 3 months ago (2014-09-23 03:55:24 UTC) #3
Weiliang
6 years, 3 months ago (2014-09-23 03:56:39 UTC) #4
Committed as r24129

Powered by Google App Engine
This is Rietveld 408576698