tools/dom/scripts/systemnative.py - Issue 589253002: Revert "Chrome 38 script changes from integration branch"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/systemnative.py

Issue 589253002: Revert "Chrome 38 script changes from integration branch" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/dom/scripts/systemnative.py

diff --git a/tools/dom/scripts/systemnative.py b/tools/dom/scripts/systemnative.py

index c6c732657726b6354777a7bd14bfc30887ac05d8..54b3ce340bde4e10a2795f01335f4fe3d9a9204b 100644

--- a/tools/dom/scripts/systemnative.py

+++ b/tools/dom/scripts/systemnative.py

@@ -1339,8 +1339,10 @@ class DartiumBackend(HtmlDartGenerator):

needs_custom_element_callbacks = False

# TODO(antonm): unify with ScriptState below.

- call_with = ext_attrs.get('CallWith', '') + ext_attrs.get('ConstructorCallWith', '')

- requires_stack_info = 'ScriptArguments' in call_with or 'ScriptState' in call_with

+ requires_stack_info = (ext_attrs.get('CallWith') == 'ScriptArguments|ScriptState' or

+ ext_attrs.get('ConstructorCallWith') == 'ScriptArguments|ScriptState' or

+ ext_attrs.get('CallWith') == 'ScriptArguments&ScriptState' or

+ ext_attrs.get('ConstructorCallWith') == 'ScriptArguments&ScriptState')

if requires_stack_info:

raises_exceptions = True

cpp_arguments = ['&state', 'scriptArguments.release()']

« no previous file with comments | « tools/dom/scripts/systemhtml.py ('k') | tools/dom/src/dart2js_KeyEvent.dart » ('j') | no next file with comments »