Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: tools/dom/scripts/generator.py

Issue 589253002: Revert "Chrome 38 script changes from integration branch" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/scripts/databasebuilder.py ('k') | tools/dom/scripts/htmlrenamer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/generator.py
diff --git a/tools/dom/scripts/generator.py b/tools/dom/scripts/generator.py
index 64db8a5b424d3afa3f6fdb7257eb9bd9b835114e..59c545882a58bdadacc342f5893d859ff5fbd902 100644
--- a/tools/dom/scripts/generator.py
+++ b/tools/dom/scripts/generator.py
@@ -114,6 +114,7 @@ _dart2js_dom_custom_native_specs = monitored.Dict(
'ChannelMergerNode': 'ChannelMergerNode,AudioChannelMerger',
'ChannelSplitterNode': 'ChannelSplitterNode,AudioChannelSplitter',
+ 'ClientRect': 'ClientRect,DOMRect',
'ClientRectList': 'ClientRectList,DOMRectList',
'CSSStyleDeclaration':
@@ -238,9 +239,9 @@ def _BuildArguments(args, interface, constructor=False):
return '_OR_'.join(sorted(set(arg.id for arg in args)))
def DartType(idl_type_name):
- if idl_type_name in _idl_type_registry:
- return _idl_type_registry[idl_type_name].dart_type or idl_type_name
- return idl_type_name
+ if idl_type_name in _idl_type_registry:
+ return _idl_type_registry[idl_type_name].dart_type or idl_type_name
+ return idl_type_name
# Given a list of overloaded arguments, choose a suitable type.
def OverloadedType(args):
@@ -449,7 +450,7 @@ class OperationInfo(object):
else:
if optional:
raise Exception('Optional parameters cannot precede required ones: '
- + str(param_info))
+ + str(params))
required.append(FormatParam(param_info))
needs_named = optional and self.requires_named_arguments and not force_optional
return (required, optional, needs_named)
« no previous file with comments | « tools/dom/scripts/databasebuilder.py ('k') | tools/dom/scripts/htmlrenamer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698