Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 589243003: Add Semaphore and its test, and use it where semaphores are needed (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add Semaphore and its test, and use it where semaphores are needed. TEST=util_test Semaphore.*:ProcessReader.*:ExceptionPorts.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/b7a10703359ab6b409c5d031e97a96df9301117a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -34 lines) Patch
M util/mac/process_reader_test.cc View 7 chunks +12 lines, -17 lines 0 comments Download
M util/mach/exception_ports_test.cc View 7 chunks +10 lines, -17 lines 0 comments Download
A util/synchronization/semaphore.h View 1 chunk +63 lines, -0 lines 0 comments Download
A util/synchronization/semaphore.cc View 1 chunk +61 lines, -0 lines 0 comments Download
A util/synchronization/semaphore_test.cc View 1 chunk +88 lines, -0 lines 0 comments Download
M util/util.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
6 years, 3 months ago (2014-09-22 23:12:12 UTC) #2
Mark Mentovai
You can hold off on this, because I want to rethink it. I might want ...
6 years, 3 months ago (2014-09-23 00:46:55 UTC) #3
Mark Mentovai
I looked at this more closely and found that it’s really not easily workable with ...
6 years, 3 months ago (2014-09-23 04:05:21 UTC) #4
Robert Sesek
LGTM. Yes, the primitives in base/ are not useful for creating a semaphore.
6 years, 3 months ago (2014-09-24 16:18:15 UTC) #5
Mark Mentovai
6 years, 3 months ago (2014-09-24 17:32:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as b7a10703359a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698