tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 858d8f9a40fd056701dd109aeebde21ddae768ab..1d9ca5b0817ef7da107593cee940826747f4a9fa 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -18995,6 +18995,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="Network.Shill.Cellular.DevicePresenceStatus"
+    enum="DevicePresenceStatus">
+  <owner>zqiu@chromium.org</owner>
+  <summary>
+    Chrome OS network metric that tracks the presence of a Cellular device in
+    the system. A sample is emitted once every 3 minutes.
+  </summary>
+</histogram>
+
 <histogram name="Network.Shill.Cellular.DHCPOptionFailureDetected"
     enum="NetworkDHCPOptionFailure">
   <obsolete>
@@ -19187,6 +19196,14 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="Network.Shill.DeviceRemovedEvent" enum="DeviceTechnologyType">
+  <owner>zqiu@chromium.org</owner>
+  <summary>
+    Chrome OS network metric that tracks the network device removed events for
+    each device type.
+  </summary>
+</histogram>
+
 <histogram name="Network.Shill.DHCPClientStatus" enum="NetworkDhcpClientStatus">
   <owner>pstew@chromium.org</owner>
   <summary>
@@ -19206,6 +19223,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="Network.Shill.Ethernet.DevicePresenceStatus"
+    enum="DevicePresenceStatus">
+  <owner>zqiu@chromium.org</owner>
+  <summary>
+    Chrome OS network metric that tracks the presence of an Ethernet device in
+    the system. A sample is emitted once every 3 minutes.
+  </summary>
+</histogram>
+
 <histogram name="Network.Shill.Ethernet.DHCPOptionFailureDetected"
     enum="NetworkDHCPOptionFailure">
   <obsolete>
@@ -19550,6 +19576,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="Network.Shill.Wifi.DevicePresenceStatus"
+    enum="DevicePresenceStatus">
+  <owner>zqiu@chromium.org</owner>
+  <summary>
+    Chrome OS network metric that tracks the presence of a WiFi device in the
+    system. A sample is emitted once every 3 minutes.
+  </summary>
+</histogram>
+
 <histogram name="Network.Shill.Wifi.DHCPOptionFailureDetected"
     enum="NetworkDHCPOptionFailure">
   <obsolete>
@@ -19916,7 +19951,16 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
-<histogram name="Network.Shill.WiMax.DHCPOptionFailureDetected"
+<histogram name="Network.Shill.Wimax.DevicePresenceStatus"
+    enum="DevicePresenceStatus">
+  <owner>zqiu@chromium.org</owner>
+  <summary>
+    Chrome OS network metric that tracks the presence of a WiMax device in the
+    system. A sample is emitted once every 3 minutes.
+  </summary>
+</histogram>
+
+<histogram name="Network.Shill.Wimax.DHCPOptionFailureDetected"
     enum="NetworkDHCPOptionFailure">
   <obsolete>
     Deprecated 5/2014, and replaced by Network.Shill.DHCPOptionFailureDetected.
@@ -19930,7 +19974,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
-<histogram name="Network.Shill.WiMax.ExpiredLeaseLengthSeconds" units="seconds">
+<histogram name="Network.Shill.Wimax.ExpiredLeaseLengthSeconds" units="seconds">
   <owner>quiche@chromium.org</owner>
   <summary>
     Chrome OS network performance metric that tracks the length of a lease for a
@@ -19939,7 +19983,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
-<histogram name="Network.Shill.WiMax.TimeToConfig" units="milliseconds">
+<histogram name="Network.Shill.Wimax.TimeToConfig" units="milliseconds">
   <owner>quiche@chromium.org</owner>
   <summary>
     Chrome OS network performance metric sampling the time to configure Layer 3
@@ -19947,7 +19991,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
-<histogram name="Network.Shill.WiMax.TimeToInitialize" units="milliseconds">
+<histogram name="Network.Shill.Wimax.TimeToInitialize" units="milliseconds">
   <owner>quiche@chromium.org</owner>
   <summary>
     Chrome OS network performance metric sampling the time to initialize a WiMax
@@ -19955,7 +19999,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
-<histogram name="Network.Shill.WiMax.TimeToOnline" units="milliseconds">
+<histogram name="Network.Shill.Wimax.TimeToOnline" units="milliseconds">
   <owner>quiche@chromium.org</owner>
   <summary>
     Chrome OS network performance metric sampling the time to determine that a
@@ -39545,6 +39589,11 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <int value="3" label="Cancel"/>
 </enum>
 
+<enum name="DevicePresenceStatus" type="int">
+  <int value="0" label="Not Present"/>
+  <int value="1" label="Present"/>
+</enum>

[Ilya Sherman, 2014/09/22 23:33:16]

nit: Please name this "BooleanPresent"

[zqiu1, 2014/09/22 23:52:27]

Will update.

+
 <enum name="DevicesPageEvents" type="int">
   <int value="0" label="OPENED"/>
   <int value="1" label="LOG_IN_STARTED_FROM_REGISTER_PROMO"/>
@@ -39561,6 +39610,14 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <int value="12" label="LOG_IN_STARTED_FROM_REGISTER_OVERLAY_PROMO"/>
 </enum>
 
+<enum name="DeviceTechnologyType" type="int">
+  <int value="0" label="Unknown"/>
+  <int value="1" label="Ethernet"/>
+  <int value="2" label="WiFi"/>
+  <int value="3" label="WiMax"/>
+  <int value="4" label="Cellular"/>
+</enum>
+
 <enum name="DevToolsAction" type="int">
   <int value="1" label="Window docked"/>
   <int value="2" label="Window undocked"/>
@@ -46954,25 +47011,27 @@ To add a new entry, add it with any value and run test to compute valid value.
 </enum>
 
 <enum name="NetworkServiceError" type="int">
-  <summary>
-    The error types come from the connman_service_error enum in
-    flimflam/include/service.h
-  </summary>
   <int value="0" label="UNKNOWN"/>
-  <int value="1" label="OUT_OF_RANGE"/>
-  <int value="2" label="PIN_MISSING"/>
-  <int value="3" label="DHCP_FAILED"/>
-  <int value="4" label="CONNECT_FAILED"/>
-  <int value="5" label="BAD_PASSPHRASE"/>
-  <int value="6" label="BAD_WEPKEY"/>
-  <int value="7" label="ACTIVATION_FAILED"/>
-  <int value="8" label="NEED_EVDO"/>
-  <int value="9" label="NEED_HOME_NETWORK"/>
-  <int value="10" label="OTASP_FAILED"/>
-  <int value="11" label="AAA_FAILED"/>
-  <int value="12" label="INTERNAL"/>
-  <int value="13" label="DNS_LOOKUP_FAILED"/>
-  <int value="14" label="HTTP_GET_FAILED"/>
+  <int value="1" label="AAA_FAILED"/>
+  <int value="2" label="ACTIVATION_FAILED"/>
+  <int value="3" label="BAD_PASSPHRASE"/>
+  <int value="4" label="BAD_WEPKEY"/>
+  <int value="5" label="CONNECT_FAILED"/>
+  <int value="6" label="DHCP_FAILED"/>
+  <int value="7" label="DNS_LOOKUP_FAILED"/>
+  <int value="8" label="EAP_AUTHENTICATION_FAILED"/>
+  <int value="9" label="EAP_LOCAL_TLS_FAILED"/>
+  <int value="10" label="EAP_REMOTE_TLS_FAILED"/>
+  <int value="11" label="HTTP_GET_FAILED"/>
+  <int value="12" label="IPSEC_CERT_AUTH_FAILED"/>
+  <int value="13" label="IPSEC_PSK_AUTH_FAILED"/>
+  <int value="14" label="INTERNAL"/>
+  <int value="15" label="NEED_EVDO"/>
+  <int value="16" label="NEED_HOME_NETWORK"/>
+  <int value="17" label="OTASP_FAILED"/>
+  <int value="18" label="OUT_OF_RANGE"/>
+  <int value="19" label="PPP_AUTH_FAILED"/>
+  <int value="20" label="PIN_MISSING"/>
 </enum>

[Ilya Sherman, 2014/09/22 23:33:16]

Hmm, why did these change?  Were they previously inaccurate, or did the enum get
re-ordered?  In general it's a Bad Idea (TM) to reorder enumerations associated
with histograms, as the labels are not versioned.  That is, if you change these
labels, you will affect the labels for this histogram across all versions of
Chrome, even though previous versions (presumably) used the previous set of
labels.

[zqiu1, 2014/09/22 23:52:27]

This enum have been inaccurate for long time, it was expanded and reordered
without much consideration long time ago.

Fix it now so we can correctly interpret the results.

[Ilya Sherman, 2014/09/23 00:02:52]

Sad times.  Is there at least a comment in place now that will discourage people
from reorganizing this enum again in the future?

FWIW, you might want to rename the histogram that emits this enum, and mark the
old name as <obsolete>, so that people are less likely to accidentally apply
inaccurate labels to old data.

 
 <enum name="NetworkTechnology" type="int">