Make HTypeofIsAndBranch accept any representation input

src/hydrogen-instructions.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 4418 matching lines @@
   HClassOfTestAndBranch(HValue* value, Handle<String> class_name)
       : HUnaryControlInstruction(value, NULL, NULL),
         class_name_(class_name) { }
 
   Handle<String> class_name_;
 };
 
 
 class HTypeofIsAndBranch V8_FINAL : public HUnaryControlInstruction {
  public:
-  DECLARE_INSTRUCTION_FACTORY_P2(HTypeofIsAndBranch, HValue*, Handle<String>);
+  static HTypeofIsAndBranch* New(Zone* zone, HValue* context,

[Jakob Kummerow, 2013/11/08 12:07:05]

Please leave the DECLARE_INSTRUCTION_FACTORY_P2 macro alone and add this logic
to the constructor. You can get the heap via type_literal->GetHeap().

[Weiliang, 2013/11/08 13:50:26]

Done.

+                                 HValue* value, Handle<String> type_literal) {
+    Heap* heap = zone->isolate()->heap();
+    bool is_number = false;

[Jakob Kummerow, 2013/11/08 12:07:05]

bool is_number = type_literal->Equals(heap->number_string());

[Weiliang, 2013/11/08 13:50:26]

Done.

+    if (type_literal->Equals(heap->number_string())) {
+      is_number = true;
+    }
+    return new(zone) HTypeofIsAndBranch(value, type_literal, is_number);
+  }
 
   Handle<String> type_literal() { return type_literal_; }
+  bool CheckNumberString() { return is_number_; }

[Jakob Kummerow, 2013/11/08 12:07:05]

I'd call the field compares_number_type_ and the accessor
compares_number_type().

[Weiliang, 2013/11/08 13:50:26]

Done.

   virtual void PrintDataTo(StringStream* stream) V8_OVERRIDE;
 
   DECLARE_CONCRETE_INSTRUCTION(TypeofIsAndBranch)
 
   virtual Representation RequiredInputRepresentation(int index) V8_OVERRIDE {
-    return Representation::Tagged();
+    return Representation::None();
   }
 
+  virtual bool KnownSuccessorBlock(HBasicBlock** block) V8_OVERRIDE;
+
  private:
-  HTypeofIsAndBranch(HValue* value, Handle<String> type_literal)
+  HTypeofIsAndBranch(HValue* value, Handle<String> type_literal, bool is_number)
       : HUnaryControlInstruction(value, NULL, NULL),
-        type_literal_(type_literal) { }
+        type_literal_(type_literal), is_number_(is_number) { }
 
   Handle<String> type_literal_;
+  bool is_number_ : 1;
 };
 
 
 class HInstanceOf V8_FINAL : public HBinaryOperation {
  public:
   DECLARE_INSTRUCTION_WITH_CONTEXT_FACTORY_P2(HInstanceOf, HValue*, HValue*);
 
   virtual Representation RequiredInputRepresentation(int index) V8_OVERRIDE {
     return Representation::Tagged();
   }
@@ skipping 2724 matching lines @@
   virtual bool IsDeletable() const V8_OVERRIDE { return true; }
 };
 
 
 #undef DECLARE_INSTRUCTION
 #undef DECLARE_CONCRETE_INSTRUCTION
 
 } }  // namespace v8::internal
 
 #endif  // V8_HYDROGEN_INSTRUCTIONS_H_