Deflake ComponentExtensionRuntimeReload test and re-enable.

Deflake ComponentExtensionRuntimeReload test and re-enable.

The test shouldn't have worked since the reload() would have prevented
the implicit domAutomationContoller.send() from executing. However,
runtime.reload() is async, so sometimes it continue executing, and
sometimes it doesn't.

BUG=407409
Committed: https://crrev.com/e84810a2eccc899460752b403a746d5cc5ffafd9
Cr-Commit-Position: refs/heads/master@{#296121}

[Anand Mistry (off Chromium), 2014-09-23 00:12:46]

amistry@chromium.org changed reviewers:
+ tapted@chromium.org

[tapted, 2014-09-23 00:16:33]

+chrome-apps-syd-reviews :)

https://codereview.chromium.org/589223003/diff/1/chrome/browser/apps/app_brow...
File chrome/browser/apps/app_browsertest.cc (right):

https://codereview.chromium.org/589223003/diff/1/chrome/browser/apps/app_brow...
chrome/browser/apps/app_browsertest.cc:1055: // Flaky: http://crbug.com/407409
This can be removed, or replaced with a brief description of the test.

https://codereview.chromium.org/589223003/diff/1/chrome/browser/apps/app_brow...
chrome/browser/apps/app_browsertest.cc:1087: ExtensionTestMessageListener
launched_listener("Launched", false);
should this come before the ExecuteScript? Otherwise I think it can miss seeing
the message. (e.g. what happens if you put a sleep(10) before this line?)

[Anand Mistry (off Chromium), 2014-09-23 00:25:43]

https://codereview.chromium.org/589223003/diff/1/chrome/browser/apps/app_brow...
File chrome/browser/apps/app_browsertest.cc (right):

https://codereview.chromium.org/589223003/diff/1/chrome/browser/apps/app_brow...
chrome/browser/apps/app_browsertest.cc:1055: // Flaky: http://crbug.com/407409
On 2014/09/23 00:16:33, tapted wrote:
> This can be removed, or replaced with a brief description of the test.

Removed. No longer relevant.

https://codereview.chromium.org/589223003/diff/1/chrome/browser/apps/app_brow...
chrome/browser/apps/app_browsertest.cc:1087: ExtensionTestMessageListener
launched_listener("Launched", false);
On 2014/09/23 00:16:33, tapted wrote:
> should this come before the ExecuteScript? Otherwise I think it can miss
seeing
> the message. (e.g. what happens if you put a sleep(10) before this line?)

Done.

[tapted, 2014-09-23 00:48:00]

lgtm

https://codereview.chromium.org/589223003/diff/1/chrome/browser/apps/app_brow...
File chrome/browser/apps/app_browsertest.cc (right):

https://codereview.chromium.org/589223003/diff/1/chrome/browser/apps/app_brow...
chrome/browser/apps/app_browsertest.cc:1087: ExtensionTestMessageListener
launched_listener("Launched", false);
On 2014/09/23 00:25:43, Anand Mistry wrote:
> On 2014/09/23 00:16:33, tapted wrote:
> > should this come before the ExecuteScript? Otherwise I think it can miss
> seeing
> > the message. (e.g. what happens if you put a sleep(10) before this line?)
> 
> Done.

(actually I realised after I sent this that a sleep(..) here probably won't make
a flake - the message will still be queued - but since
ExecuteScriptInBackgroundPageNoWait(.) is spinning its own runloops, it's better
to have the listener listening throughout.) /allgood

[Anand Mistry (off Chromium), 2014-09-23 00:50:42]

The CQ bit was checked by amistry@chromium.org

[commit-bot: I haz the power, 2014-09-23 00:51:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/589223003/20001

[commit-bot: I haz the power, 2014-09-23 01:31:33]

Committed patchset #2 (id:20001) as 129c728bcd73b0c63c5d9e4a91b79bc204be65e7

[commit-bot: I haz the power, 2014-09-23 01:32:05]

Patchset 2 (id:??) landed as
https://crrev.com/e84810a2eccc899460752b403a746d5cc5ffafd9
Cr-Commit-Position: refs/heads/master@{#296121}