chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc - Issue 589153002: Remove void* in WebRequestEventRouterDelegate

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc

Issue 589153002: Remove void* in WebRequestEventRouterDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/activity_log/web_request_constants.h » ('j') | chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/values.h"	5 #include "base/values.h"

6 #include "chrome/browser/extensions/activity_log/activity_action_constants.h"	6 #include "chrome/browser/extensions/activity_log/activity_action_constants.h"

7 #include "chrome/browser/extensions/activity_log/activity_actions.h"	7 #include "chrome/browser/extensions/activity_log/activity_actions.h"

8 #include "chrome/browser/extensions/activity_log/activity_log_policy.h"	8 #include "chrome/browser/extensions/activity_log/activity_log_policy.h"

9 #include "chrome/browser/extensions/activity_log/web_request_constants.h"	9 #include "extensions/browser/api/activity_log/web_request_constants.h"

10 #include "extensions/common/value_builder.h"	10 #include "extensions/common/value_builder.h"

11 #include "testing/gtest/include/gtest/gtest.h"	11 #include "testing/gtest/include/gtest/gtest.h"

12	12

13 namespace extensions {	13 namespace extensions {

14	14

15 class ActivityLogPolicyUtilTest : public testing::Test {};	15 class ActivityLogPolicyUtilTest : public testing::Test {};

16	16

17 // Test that incognito values are stripped, and non-incognito ones aren't.	17 // Test that incognito values are stripped, and non-incognito ones aren't.

18 TEST_F(ActivityLogPolicyUtilTest, StripPrivacySensitive) {	18 TEST_F(ActivityLogPolicyUtilTest, StripPrivacySensitive) {

19 scoped_refptr<Action> action =	19 scoped_refptr<Action> action =

(...skipping 67 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
87 new Action("punky",	87 new Action("punky",

88 base::Time::Now(),	88 base::Time::Now(),

89 Action::ACTION_API_CALL,	89 Action::ACTION_API_CALL,

90 "tabs.executeScript");	90 "tabs.executeScript");

91 action->ParsePageUrl("<incognito>http://www.google.com/");	91 action->ParsePageUrl("<incognito>http://www.google.com/");

92 EXPECT_EQ("http://www.google.com/", action->page_url().spec());	92 EXPECT_EQ("http://www.google.com/", action->page_url().spec());

93 EXPECT_TRUE(action->page_incognito());	93 EXPECT_TRUE(action->page_incognito());

94 }	94 }

95	95

96 } // namespace extensions	96 } // namespace extensions

OLD	NEW