Remove void* in WebRequestEventRouterDelegate

This is a follow up patch for "Introduce WebRequestEventRouterDelegate.".

In this CL, we avoid leaking the void* pointer of profile outside of
web_request_api.cc. The main idea behind is void* is used in webrequest API to
avoid accidently access to profile on IO thread. When we are certain that a
function is called on UI thread, we can cast the void* to BrowserContext*.

A refactor is made to
WebRequestEventRouterDelegate::LogExtensionActivity(...):
-Change its first parameter from void* to BrowserContext*; So we won't leak void* pointer outside of web_request_api.cc.
-This function only keeps the logic that is run on UI thread, the logic for IO thread is moved back to web_request_api.cc.

BUG=352293
Committed: https://crrev.com/ff4501a8bfde696715311c752104d17102e0d894
Cr-Commit-Position: refs/heads/master@{#296040}

[Xi Han, 2014-09-22 17:17:23]

hanxi@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2014-09-22 17:21:21]

https://codereview.chromium.org/589153002/diff/1/chrome/browser/extensions/ap...
File
chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc
(right):

https://codereview.chromium.org/589153002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc:50:
content::BrowserContext* browser_context_id,
browser_context

https://codereview.chromium.org/589153002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc:58:
static_cast<content::BrowserContext*>(browser_context_id);
Remove this?

https://codereview.chromium.org/589153002/diff/1/chrome/browser/extensions/ap...
File
chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.h
(right):

https://codereview.chromium.org/589153002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.h:24:
content::BrowserContext* browser_context_id,
rename to browser_context

https://codereview.chromium.org/589153002/diff/1/extensions/browser/api/web_r...
File extensions/browser/api/web_request/web_request_event_router_delegate.h
(right):

https://codereview.chromium.org/589153002/diff/1/extensions/browser/api/web_r...
extensions/browser/api/web_request/web_request_event_router_delegate.h:50:
content::BrowserContext* browser_context_id,
Rename to browser_context

[Xi Han, 2014-09-22 17:49:51]

Patchset #2 (id:20001) has been deleted

[Xi Han, 2014-09-22 17:50:26]

https://codereview.chromium.org/589153002/diff/1/chrome/browser/extensions/ap...
File
chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc
(right):

https://codereview.chromium.org/589153002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc:50:
content::BrowserContext* browser_context_id,
On 2014/09/22 17:21:21, Fady Samuel wrote:
> browser_context

Done.

https://codereview.chromium.org/589153002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc:58:
static_cast<content::BrowserContext*>(browser_context_id);
On 2014/09/22 17:21:21, Fady Samuel wrote:
> Remove this?

Great catch, thanks.

https://codereview.chromium.org/589153002/diff/1/chrome/browser/extensions/ap...
File
chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.h
(right):

https://codereview.chromium.org/589153002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.h:24:
content::BrowserContext* browser_context_id,
On 2014/09/22 17:21:21, Fady Samuel wrote:
> rename to browser_context

Done.

https://codereview.chromium.org/589153002/diff/1/extensions/browser/api/web_r...
File extensions/browser/api/web_request/web_request_event_router_delegate.h
(right):

https://codereview.chromium.org/589153002/diff/1/extensions/browser/api/web_r...
extensions/browser/api/web_request/web_request_event_router_delegate.h:50:
content::BrowserContext* browser_context_id,
On 2014/09/22 17:21:21, Fady Samuel wrote:
> Rename to browser_context

Done.

[Fady Samuel, 2014-09-22 18:01:23]

lgtm

[Xi Han, 2014-09-22 18:08:11]

hanxi@chromium.org changed reviewers:
+ rockot@chromium.org

[Xi Han, 2014-09-22 18:08:12]

rockot@chromium.org: Please review all changes.

[Ken Rockot(use gerrit already), 2014-09-22 20:17:41]

lgtm

[Xi Han, 2014-09-22 20:20:43]

The CQ bit was checked by hanxi@chromium.org

[commit-bot: I haz the power, 2014-09-22 20:21:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/589153002/100001

[commit-bot: I haz the power, 2014-09-22 20:29:43]

Committed patchset #5 (id:100001) as 81cf86d315f2f6652d38f768efac8be84c27e0c1

[commit-bot: I haz the power, 2014-09-22 20:30:14]

Patchset 5 (id:??) landed as
https://crrev.com/ff4501a8bfde696715311c752104d17102e0d894
Cr-Commit-Position: refs/heads/master@{#296040}