Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 589143002: [Android WebView] Run license scanning in parallel (Closed)

Created:
6 years, 3 months ago by mnaganov (inactive)
Modified:
6 years, 3 months ago
Reviewers:
mkosiba (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android WebView] Run license scanning in parallel Split the Perl script into 2 and shard the actual checking, so we can run it in parallel. On bots, this reduces the time needed to complete "check licenses" step from 3-4 mins to 40 seconds! I'm planning to rewrite the scanner in Python soon, but I see that this change can already help running trybots faster. BUG=416496 Committed: https://crrev.com/c7b282ab7d4cb585f2bafe33033223967f8ed887 Cr-Commit-Position: refs/heads/master@{#296207}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -41 lines) Patch
M android_webview/tools/find_copyrights.pl View 2 chunks +7 lines, -24 lines 0 comments Download
A android_webview/tools/find_files.pl View 1 chunk +32 lines, -0 lines 2 comments Download
M android_webview/tools/webview_licenses.py View 3 chunks +50 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
mnaganov (inactive)
6 years, 3 months ago (2014-09-22 16:37:15 UTC) #2
mnaganov (inactive)
Ping!
6 years, 3 months ago (2014-09-23 14:28:21 UTC) #3
mkosiba (inactive)
lgtm https://codereview.chromium.org/589143002/diff/1/android_webview/tools/find_files.pl File android_webview/tools/find_files.pl (right): https://codereview.chromium.org/589143002/diff/1/android_webview/tools/find_files.pl#newcode2 android_webview/tools/find_files.pl:2: # Copyright 2013 The Chromium Authors. All rights ...
6 years, 3 months ago (2014-09-23 15:53:52 UTC) #4
mnaganov (inactive)
https://codereview.chromium.org/589143002/diff/1/android_webview/tools/find_files.pl File android_webview/tools/find_files.pl (right): https://codereview.chromium.org/589143002/diff/1/android_webview/tools/find_files.pl#newcode2 android_webview/tools/find_files.pl:2: # Copyright 2013 The Chromium Authors. All rights reserved. ...
6 years, 3 months ago (2014-09-23 16:13:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589143002/1
6 years, 3 months ago (2014-09-23 16:14:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 26193be19389132875612a88763810258be0be9d
6 years, 3 months ago (2014-09-23 16:55:46 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 16:57:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7b282ab7d4cb585f2bafe33033223967f8ed887
Cr-Commit-Position: refs/heads/master@{#296207}

Powered by Google App Engine
This is Rietveld 408576698