Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 58913003: command_buffer: Remove hash_tables.h, simplify atomicops.h (Closed)

Created:
7 years, 1 month ago by Nico
Modified:
7 years, 1 month ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, apatrick_chromium
Visibility:
Public.

Description

command_buffer: Remove hash_tables.h, simplify atomicops.h command_buffer was historically included in nacl-compiled things, and base wasn't. These days, base is included in nacl-compiled things too, so the duplication can be removed. BUG=none R=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233098

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -44 lines) Patch
M gpu/command_buffer/client/atomicops.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/atomicops.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M gpu/command_buffer/client/buffer_tracker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gpu_memory_buffer_tracker.h View 2 chunks +2 lines, -2 lines 0 comments Download
D gpu/command_buffer/client/hash_tables.h View 1 chunk +0 lines, -24 lines 0 comments Download
M gpu/command_buffer/client/query_tracker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/query_tracker.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/vertex_array_object_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer_client.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
atomicops.h/cc can go completely I think, but I'll do that in a followup.
7 years, 1 month ago (2013-11-05 05:56:40 UTC) #1
Nico
piman: Can you stamp this too? It's a prerequisite for https://codereview.chromium.org/59383006/ which you already approved. ...
7 years, 1 month ago (2013-11-05 19:58:13 UTC) #2
piman
lgtm
7 years, 1 month ago (2013-11-05 20:58:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/58913003/80001
7 years, 1 month ago (2013-11-05 21:11:42 UTC) #4
Nico
7 years, 1 month ago (2013-11-05 22:08:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r233098 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698