Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 58913002: [rAc OSX] Ensure that the "Save in Chrome?" tooltip is only visible when the checkbox is. (Closed)

Created:
7 years, 1 month ago by Ilya Sherman
Modified:
7 years, 1 month ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

[rAc OSX] Ensure that the "Save in Chrome?" tooltip is only visible when the checkbox is. BUG=314959 TEST=unit_tests R=groby@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233395

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/ui/cocoa/autofill/autofill_main_container.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_main_container_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ilya Sherman
7 years, 1 month ago (2013-11-05 04:24:18 UTC) #1
groby-ooo-7-16
lgtm
7 years, 1 month ago (2013-11-06 01:34:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/58913002/1
7 years, 1 month ago (2013-11-06 01:35:09 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=98383
7 years, 1 month ago (2013-11-06 06:07:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/58913002/1
7 years, 1 month ago (2013-11-06 07:07:43 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=98474
7 years, 1 month ago (2013-11-06 09:41:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/58913002/1
7 years, 1 month ago (2013-11-06 20:08:54 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 22:19:45 UTC) #8
Message was sent while issue was closed. 
Change committed as 233395

Powered by Google App Engine
This is Rietveld 408576698