Issue 589123002: Add a PRESUBMIT check that production code does not call test code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 589123002: Add a PRESUBMIT check that production code does not call test code (Closed)

Created:
6 years, 3 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 3 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Add a PRESUBMIT check that production code does not call test code This is based on a regular expression matching anything in a namespace ending in test, or a method containing the words ForTest, ForTesting, for_test, or for_testing. It is possible to blacklist entire directories or individual files. BUG=none LOG=n R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24134

Patch Set 1 #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -0 lines)			Patch
	M	PRESUBMIT.py	View		3 chunks	+71 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM, love it! https://codereview.chromium.org/589123002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/589123002/diff/1/PRESUBMIT.py#newcode49 PRESUBMIT.py:49: # Has a method VisitForTest(). Please ...

6 years, 3 months ago (2014-09-22 22:25:51 UTC) #1

jochen (gone - plz use gerrit)

6 years, 3 months ago (2014-09-23 08:14:16 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 24134 (presubmit successful).

Expand Messages | Collapse Messages