Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1670)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java

Issue 589113002: Rename java WebContentsObserverAndroid to WebContentsObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java b/content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java
similarity index 93%
rename from content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
rename to content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java
index 6237141ef2208402a763b2515d4c268122c93d5e..35b228d590455c31f56db82054a01f77fda3e585 100644
--- a/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
+++ b/content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java
@@ -14,12 +14,12 @@ import org.chromium.content_public.browser.WebContents;
* to loading a url. A single web contents can have multiple WebContentObserverAndroids.
*/
@JNINamespace("content")
-public abstract class WebContentsObserverAndroid {
- private long mNativeWebContentsObserverAndroid;
+public abstract class WebContentsObserver {
+ private long mNativeWebContentsObserver;
- public WebContentsObserverAndroid(WebContents webContents) {
+ public WebContentsObserver(WebContents webContents) {
ThreadUtils.assertOnUiThread();
- mNativeWebContentsObserverAndroid = nativeInit(webContents);
+ mNativeWebContentsObserver = nativeInit(webContents);
}
@CalledByNative
@@ -170,12 +170,12 @@ public abstract class WebContentsObserverAndroid {
*/
@CalledByNative
public void detachFromWebContents() {
- if (mNativeWebContentsObserverAndroid != 0) {
- nativeDestroy(mNativeWebContentsObserverAndroid);
- mNativeWebContentsObserverAndroid = 0;
+ if (mNativeWebContentsObserver != 0) {
+ nativeDestroy(mNativeWebContentsObserver);
+ mNativeWebContentsObserver = 0;
}
}
private native long nativeInit(WebContents webContents);
- private native void nativeDestroy(long nativeWebContentsObserverAndroid);
+ private native void nativeDestroy(long nativeWebContentsObserver);
nyquist 2014/09/22 22:16:58 This parameter name still needs to be nativeWebCon
wajahat 2014/09/25 12:20:46 Done.
}

Powered by Google App Engine
This is Rietveld 408576698