Rename java WebContentsObserverAndroid to WebContentsObserver

content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser;
 
 import org.chromium.base.CalledByNative;

[nyquist, 2014/09/25 16:57:28]

remove this and JNINamespace after you remove all the overrides.

[wajahat, 2014/09/29 14:43:25]

Done.

 import org.chromium.base.JNINamespace;
-import org.chromium.base.ThreadUtils;
+import org.chromium.content.browser.WebContentsObserver;

[nyquist, 2014/09/25 16:57:28]

They are in the same package, so this in unnecessary.

[wajahat, 2014/09/29 14:43:24]

Done.

 import org.chromium.content_public.browser.WebContents;
 
 /**
+ * @deprecated This class is renamed to WebContentsObserver

[nyquist, 2014/09/25 16:57:28]

Could you use {@link WebContentsObserver}?
Also, just remove the old comment, and add a reference to a bug.

How about:
/**
 * @deprecated This class has been renamed to {@link }WebContentsObserver} and
will be removed when
 * all usages have been removed. See http://crbug.com/396118.
 */
@Deprecated
public abstract class ...

[wajahat, 2014/09/29 14:43:25]

Done.

+ * in future this will be removed.
+ */
+@Deprecated
+/**
  * This class receives callbacks that act as hooks for various a native web contents events related
  * to loading a url. A single web contents can have multiple WebContentObserverAndroids.
  */
 @JNINamespace("content")

[nyquist, 2014/09/25 16:57:28]

This annotation should not be needed anymore.

[wajahat, 2014/09/29 14:43:25]

Done.

-public abstract class WebContentsObserverAndroid {
-    private long mNativeWebContentsObserverAndroid;
+public abstract class WebContentsObserverAndroid extends WebContentsObserver {
 
     public WebContentsObserverAndroid(WebContents webContents) {
-        ThreadUtils.assertOnUiThread();
-        mNativeWebContentsObserverAndroid = nativeInit(webContents);
+        super(webContents);
     }
 
     @CalledByNative

[nyquist, 2014/09/25 16:57:28]

I don't think these annotations are needed anymore as this file is not processed
by the JNI generator. Also, do you need to have these methods at all?

[wajahat, 2014/09/29 14:43:25]

Done.

     public void renderProcessGone(boolean wasOomProtected) {

[nyquist, 2014/09/25 16:57:28]

In fact, you can just remove all the methods in this class and just keep the
constructor.

[Yaron, 2014/09/25 22:46:16]

Right. If you didn't remove them this would actually break things as
detachFromWebContents doesn't call up to its parent class which means we'd leak
the reference.

[wajahat, 2014/09/29 14:43:24]

Done.

[wajahat, 2014/09/29 14:43:25]

Done.

[wajahat, 2014/09/29 14:43:25]

Done.

     }
 
     /**
      * Called when the a page starts loading.
      * @param url The validated url for the loading page.
      */
     @CalledByNative
     public void didStartLoading(String url) {
     }
 
@@ skipping 126 matching lines @@
      */
     @CalledByNative
     public void didChangeThemeColor(int color) {
     }
 
     /**
      * Destroy the corresponding native object.
      */
     @CalledByNative
     public void detachFromWebContents() {
-        if (mNativeWebContentsObserverAndroid != 0) {
-            nativeDestroy(mNativeWebContentsObserverAndroid);
-            mNativeWebContentsObserverAndroid = 0;
-        }
     }
-
-    private native long nativeInit(WebContents webContents);
-    private native void nativeDestroy(long nativeWebContentsObserverAndroid);
 }