Issue 589093003: Revert of Let --js-flags work when Harmony is enabled in about:flags

Issue 589093003: Revert of Let --js-flags work when Harmony is enabled in about:flags (Closed)

Created:
6 years, 3 months ago by Mathieu

Modified:
6 years, 3 months ago

Reviewers:
Erik Corry, jochen (gone - plz use gerrit), Erik Corry Chromium.org

CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, nasko+codewatch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of Let --js-flags work when Harmony is enabled in about:flags (patchset #2 id:20001 of https://codereview.chromium.org/588543003/) Reason for revert: Breaks unit_tests http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/3714 Original issue's description: > Let --js-flags work when Harmony is enabled in about:flags > > R=jochen@chromium.org > BUG= > > Committed: https://crrev.com/727cae88098c3fd91df47afa64cb756b54050b20 > Cr-Commit-Position: refs/heads/master@{#295960} TBR=jochen@chromium.org,erik.corry@gmail.com,erikcorry@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/e275624158e664f5845047ad40ac0a07f5c06d7c Cr-Commit-Position: refs/heads/master@{#295970}

Created: 6 years, 3 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1 line, -11 lines)			Patch
M	chrome/browser/about_flags.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/renderer/chrome_render_process_observer.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

Mathieu

Created Revert of Let --js-flags work when Harmony is enabled in about:flags

6 years, 3 months ago (2014-09-22 14:37:54 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589093003/1

6 years, 3 months ago (2014-09-22 14:38:09 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as 0e999ffed6a33faca1a74ce67898a453faf1aa23

6 years, 3 months ago (2014-09-22 14:38:34 UTC) #3

commit-bot: I haz the power

6 years, 3 months ago (2014-09-22 14:39:28 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e275624158e664f5845047ad40ac0a07f5c06d7c
Cr-Commit-Position: refs/heads/master@{#295970}