Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: pkg/watcher/test/directory_watcher/mac_os_test.dart

Issue 58903015: Fix the Mac OS directory watcher tests on the bots. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/watcher/test/directory_watcher/mac_os_test.dart
diff --git a/pkg/watcher/test/directory_watcher/mac_os_test.dart b/pkg/watcher/test/directory_watcher/mac_os_test.dart
index 78ff8898515ad3441327ea701c2263b912a6e784..b6a65e6e239d46f6f46a64f21dbc3fad6a8e0b6b 100644
--- a/pkg/watcher/test/directory_watcher/mac_os_test.dart
+++ b/pkg/watcher/test/directory_watcher/mac_os_test.dart
@@ -50,6 +50,29 @@ main() {
() {
withPermutations((i, j, k) =>
writeFile("dir/sub/sub-$i/sub-$j/file-$k.txt"));
+
+ // We sleep here because a narrow edge case caused by two interacting bugs
+ // can produce events that aren't expected if we start the watcher too
+ // soon after creating the files above. Here's what happens:
+ //
+ // * We create "dir/sub" and its contents above.
+ //
+ // * We initialize the watcher watching "dir".
+ //
+ // * Due to issue 14373, the watcher can receive native events describing
+ // the creation of "dir/sub" and its contents despite the fact that they
+ // occurred before the watcher was started.
+ //
+ // * Usually the above events will occur while the watcher is doing its
+ // initial scan of "dir/sub" and be ignored, but occasionally they will
+ // occur afterwards.
+ //
+ // * When processing the bogus CREATE events, the watcher has to assume that
+ // they could mean something other than CREATE (issue 14793). Thus it
+ // assumes that the files or directories in question could have changed
+ // and emits CHANGE events or additional REMOVE/CREATE pairs for them.
+ schedule(() => new Future.delayed(new Duration(seconds: 2)));
+
startWatcher(dir: "dir");
renameDir("dir/sub", "sub");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698