Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 58903014: Revert 232412 "Implement Google network speech synthesis." (Closed)

Created:
7 years, 1 month ago by dmazzoni
Modified:
7 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Revert 232412 "Implement Google network speech synthesis." > Implement Google network speech synthesis. > > See bug for context. Implements a component extension > that provides speech synthesis using Google's speech > synthesis API. > > Adds a "remote" flag to the TTS and TTS Engine APIs > so that it's possible for clients to distinguish > between local and remote speech engines. > > Adds a new private extension API to expose Google's > API key, needed to make the request. > > BUG=308250 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232242 > > Review URL: https://codereview.chromium.org/27034009 TBR=dmazzoni@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235464

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -507 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/system_private/system_private_api.h View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/system_private/system_private_api.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/component_loader.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_function_histogram_value.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/resources/network_speech_synthesis/manifest.json View 1 chunk +0 lines, -90 lines 0 comments Download
D chrome/browser/resources/network_speech_synthesis/tts_extension.js View 1 chunk +0 lines, -251 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_engine_extension_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/speech/extension_api/tts_extension_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/speech/extension_api/tts_extension_api_constants.h View 1 chunk +21 lines, -22 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_extension_api_constants.cc View 1 chunk +22 lines, -23 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_extension_apitest.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/speech/tts_controller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/speech/tts_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/speech/tts_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/speech/tts_engine_manifest_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/speech/tts_engine_manifest_handler.cc View 2 chunks +1 line, -9 lines 0 comments Download
M chrome/common/extensions/api/system_private.json View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/common/extensions/api/tts.json View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/test/data/extensions/api_test/tts_engine/network_speech_engine/manifest.json View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/test/data/extensions/api_test/tts_engine/network_speech_engine/test.js View 1 chunk +0 lines, -17 lines 0 comments Download
M extensions/common/manifest_constants.h View 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/common/manifest_constants.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dmazzoni
7 years, 1 month ago (2013-11-15 23:11:27 UTC) #1
dmazzoni
7 years, 1 month ago (2013-11-15 23:11:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r235464.

Powered by Google App Engine
This is Rietveld 408576698