Issue 58903012: Observe in views::InputMethodBridge if host IME is destroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 58903012: Observe in views::InputMethodBridge if host IME is destroyed (Closed)

Created:
7 years, 1 month ago by mohsen

Modified:
7 years, 1 month ago

Reviewers:
Seigo Nonaka

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, penghuang+watch_chromium.org, nona+watch_chromium.org, timurrrr+watch_chromium.org, James Su, glider+watch_chromium.org, bruening+watch_chromium.org, yoichio, yukawa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Observe in views::InputMethodBridge if host IME is destroyed Sometimes, before the widget and its corresponding input method bridge is destroyed, the host input method used by the bridge is destroyed. This can especially happen in unit tests. So, input method bridge should observe the host input method to avoid calling methods on it if it is destroyed. The tests that were disabled because of this issue are re-enabled, too. BUG=315883 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236186

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -10 lines)			Patch
D	tools/heapcheck/ash_unittests.gtest-heapcheck.txt	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	tools/valgrind/gtest_exclude/ash_unittests.gtest-memcheck.txt	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	ui/views/ime/input_method_bridge.h	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	ui/views/ime/input_method_bridge.cc	View	7 chunks	+79 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/58903012/1

7 years, 1 month ago (2013-11-20 03:50:58 UTC) #4

Message was sent while issue was closed.

Change committed as 236186

Expand Messages | Collapse Messages