tests_lit/llvm2ice_tests/returns_twice_no_coalesce.ll - Issue 589003002: Subzero: Refactor tracking of Defs and block-local Variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests_lit/llvm2ice_tests/returns_twice_no_coalesce.ll

Issue 589003002: Subzero: Refactor tracking of Defs and block-local Variables. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: "Mark args as being used in the entry node" was unnecessary. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests_lit/llvm2ice_tests/returns_twice_no_coalesce.ll

diff --git a/tests_lit/llvm2ice_tests/returns_twice_no_coalesce.ll b/tests_lit/llvm2ice_tests/returns_twice_no_coalesce.ll

index 754a105b01591191e3a267314e3f31a5bacf1722..67654af4ccca3dd6ac9e7e5741a7e0e918e6f5fe 100644

--- a/tests_lit/llvm2ice_tests/returns_twice_no_coalesce.ll

+++ b/tests_lit/llvm2ice_tests/returns_twice_no_coalesce.ll

@@ -55,6 +55,9 @@ NonZero:

; CHECK: mov dword ptr [esp + [[OFF:.*]]], [[REG1]]

; CHECK: add [[REG2:.*]], 54321

; Now there should be sharing of the stack slot (OFF is the same).

-; CHECK: mov dword ptr [esp + [[OFF]]], [[REG2]]

+; Commenting out after disabling simple coalescing for -Om1.

+; TODO(stichnot): Add it back if/when we add a flag to enable simple

+; coalescing.

+; xCHECK: mov dword ptr [esp + [[OFF]]], [[REG2]]

; ERRORS-NOT: ICE translation error

« no previous file with comments | « tests_lit/llvm2ice_tests/align-spill-locations.ll ('k') | no next file » | no next file with comments »