Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: src/IceCfgNode.cpp

Issue 589003002: Subzero: Refactor tracking of Defs and block-local Variables. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: "Mark args as being used in the entry node" was unnecessary. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceCfg.cpp ('k') | src/IceConverter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceCfgNode.cpp
diff --git a/src/IceCfgNode.cpp b/src/IceCfgNode.cpp
index 2b05e58d6730ff74b1ca9b671ca5058e16f4e9c8..32775643c7a75873de10284f95debd9f7ab4a777 100644
--- a/src/IceCfgNode.cpp
+++ b/src/IceCfgNode.cpp
@@ -47,7 +47,6 @@ void CfgNode::appendInst(Inst *Inst) {
} else {
Insts.push_back(Inst);
}
- Inst->updateVars(this);
}
// Renumbers the non-deleted instructions in the node. This needs to
@@ -92,9 +91,8 @@ void CfgNode::computePredecessors() {
// blocks. Note that this transformation preserves SSA form.
void CfgNode::placePhiLoads() {
for (PhiList::iterator I = Phis.begin(), E = Phis.end(); I != E; ++I) {
- Inst *Inst = (*I)->lower(Func, this);
+ Inst *Inst = (*I)->lower(Func);
Insts.insert(Insts.begin(), Inst);
- Inst->updateVars(this);
}
}
@@ -213,7 +211,6 @@ void CfgNode::placePhiStores() {
Insts.insert(SafeInsertionPoint, NewInst);
else
Insts.insert(InsertionPoint, NewInst);
- NewInst->updateVars(this);
}
}
}
@@ -281,12 +278,12 @@ void CfgNode::livenessLightweight() {
I != E; ++I) {
if ((*I)->isDeleted())
continue;
- (*I)->livenessLightweight(Live);
+ (*I)->livenessLightweight(Func, Live);
}
for (PhiList::const_iterator I = Phis.begin(), E = Phis.end(); I != E; ++I) {
if ((*I)->isDeleted())
continue;
- (*I)->livenessLightweight(Live);
+ (*I)->livenessLightweight(Func, Live);
}
}
« no previous file with comments | « src/IceCfg.cpp ('k') | src/IceConverter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698