Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 588993002: [ServiceWorker] Remove the test for the rejected result of FetchEvent from fetch-event.html (Closed)

Created:
6 years, 3 months ago by horo
Modified:
6 years, 3 months ago
Reviewers:
yhirano
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Remove the test for the rejected result of FetchEvent from fetch-event.html We don't have the way to observe the network error using <iframe>. So this change removes the rejecting test from fetch-event.html I will introduce the reject test using XMLHttpRequest later. (step 3) Step1: this patch [ServiceWorker] Remove the test for the rejected result of FetchEvent from fetch-event.html https://codereview.chromium.org/588993002/ Step2: [ServiceWorker] Treat the rejected result of onFetch as a Network Error. https://codereview.chromium.org/590043002/ Step3: [ServiceWorker] Add test for the rejected result of FetchEvent using XHR. https://codereview.chromium.org/588093003/ BUG=411173 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182401

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M LayoutTests/http/tests/serviceworker/fetch-event.html View 1 chunk +0 lines, -15 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/fetch-event-test-worker.js View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
horo
yhirano@ Could you please review?
6 years, 3 months ago (2014-09-22 05:29:20 UTC) #2
yhirano
lgtm
6 years, 3 months ago (2014-09-22 07:43:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588993002/1
6 years, 3 months ago (2014-09-22 07:59:00 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 09:05:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182401

Powered by Google App Engine
This is Rietveld 408576698