Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: ui/base/ui_base_tests.gyp

Issue 588963002: Start the process of renaming ui_unittests to ui_base_unittests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix it? Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ui_base_tests.gyp
diff --git a/ui/base/ui_base_tests.gyp b/ui/base/ui_base_tests.gyp
index 945a9ec2d805f1b15140ba581135b0384b55a234..0db57be7a4767f11c7e2f146c9ce4629fd360c1c 100644
--- a/ui/base/ui_base_tests.gyp
+++ b/ui/base/ui_base_tests.gyp
@@ -8,14 +8,8 @@
},
'targets': [
{
- # TODO(tfarina): Rename this target to ui_base_unittests.
- # In order to do this we will need to keep this target, add a dummy
- # ui_base_unittests target that just points to ui_unittests, change
- # buildbot code to reference the new 'ui_base_unittests' target.
- # After buildbot is updated, we can make the changes in Chromium and
- # remove 'ui_unittests' target. crbug.com/331829
# GN version: //ui/base:unittests
- 'target_name': 'ui_unittests',
+ 'target_name': 'ui_base_unittests',
'type': '<(gtest_target_type)',
'dependencies': [
'../../base/base.gyp:base',
@@ -233,6 +227,66 @@
}],
],
},
+ {
+ # TODO(tfarina): Remove this target after all traces of it are updated to
+ # point to ui_base_unittests. That means updating buildbot code and some
+ # references in chromium too. crbug.com/331829
+ 'target_name': 'ui_unittests',
+ 'type': 'none',
+ 'dependencies': [
+ 'ui_base_unittests',
+ ],
+ 'conditions': [
+ ['OS != "ios"',
+ {
+ 'actions': [
+ {
+ 'message': 'TEMPORARY: Copying ui_base_unittests to ui_unittests',
+ 'action_name': 'copy_ui_base_unittests',
+ 'variables': {
+ 'source_file': '<(PRODUCT_DIR)/ui_base_unittests<(EXECUTABLE_SUFFIX)',
cjhopman 2014/09/22 00:07:40 It the only difference is in the variables, why no
tfarina 2014/09/22 00:53:15 Done.
+ 'dest_file': '<(PRODUCT_DIR)/ui_unittests<(EXECUTABLE_SUFFIX)',
+ },
+ 'inputs': [
+ '../../build/cp.py',
+ '<(source_file)',
+ ],
+ 'outputs': [
+ '<(dest_file)',
+ ],
+ 'action': [
+ 'python', '../../build/cp.py', '<(source_file)', '<(dest_file)',
+ ],
+ },
+ ],
+ },
+ ],
+ ['OS == "ios"',
+ {
+ 'actions': [
+ {
+ 'message': 'TEMPORARY: Copying ui_base_unittests to ui_unittests',
+ 'action_name': 'copy_ui_base_unittests',
+ 'variables': {
+ 'source_file': '<(PRODUCT_DIR)/ui_base_unittests.app/ui_base_unittests',
+ 'dest_file': '<(PRODUCT_DIR)/ui_unittests.app/ui_unittests',
+ },
+ 'inputs': [
+ '../../build/cp.py',
+ '<(source_file)',
+ ],
+ 'outputs': [
+ '<(dest_file)',
+ ],
+ 'action': [
+ 'python', '../../build/cp.py', '<(source_file)', '<(dest_file)',
+ ],
+ },
+ ],
+ },
+ ],
+ ],
+ },
],
'conditions': [
# Mac target to build a test Framework bundle to mock out resource loading.
@@ -255,9 +309,10 @@
'type': 'none',
'dependencies': [
'ui_unittests',
+ 'ui_base_unittests',
],
'variables': {
- 'test_suite_name': 'ui_unittests',
+ 'test_suite_name': 'ui_base_unittests',
},
'includes': [ '../../build/apk_test.gypi' ],
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698