Chromium Code Reviews| Index: ui/base/ui_base_tests.gyp |
| diff --git a/ui/base/ui_base_tests.gyp b/ui/base/ui_base_tests.gyp |
| index 945a9ec2d805f1b15140ba581135b0384b55a234..5cb5014fe9ffb16b6d4f60216fc015aecbac9553 100644 |
| --- a/ui/base/ui_base_tests.gyp |
| +++ b/ui/base/ui_base_tests.gyp |
| @@ -8,14 +8,8 @@ |
| }, |
| 'targets': [ |
| { |
| - # TODO(tfarina): Rename this target to ui_base_unittests. |
| - # In order to do this we will need to keep this target, add a dummy |
| - # ui_base_unittests target that just points to ui_unittests, change |
| - # buildbot code to reference the new 'ui_base_unittests' target. |
| - # After buildbot is updated, we can make the changes in Chromium and |
| - # remove 'ui_unittests' target. crbug.com/331829 |
| # GN version: //ui/base:unittests |
| - 'target_name': 'ui_unittests', |
| + 'target_name': 'ui_base_unittests', |
| 'type': '<(gtest_target_type)', |
| 'dependencies': [ |
| '../../base/base.gyp:base', |
| @@ -233,6 +227,50 @@ |
| }], |
| ], |
| }, |
| + { |
| + # TODO(tfarina): Remove this target after all traces of it are updated to |
| + # point to ui_base_unittests. That means updating buildbot code and some |
| + # references in chromium too. crbug.com/331829 |
| + 'target_name': 'ui_unittests', |
| + 'type': 'none', |
| + 'dependencies': [ |
| + 'ui_base_unittests', |
| + ], |
| + 'actions': [ |
| + { |
| + 'message': 'TEMPORARY: Copying ui_base_unittests to ui_unittests', |
| + 'action_name': 'copy_ui_base_unittests', |
| + 'conditions': [ |
| + ['OS != "ios" or OS != "android"', |
|
cjhopman
2014/09/22 01:03:14
s/or/and
also, we don't want this action at all o
tfarina
2014/09/22 01:23:52
Done.
|
| + { |
| + 'variables': { |
| + 'source_file': '<(PRODUCT_DIR)/ui_base_unittests<(EXECUTABLE_SUFFIX)', |
| + 'dest_file': '<(PRODUCT_DIR)/ui_unittests<(EXECUTABLE_SUFFIX)', |
| + }, |
| + }, |
| + ], |
| + ['OS == "ios"', |
| + { |
| + 'variables': { |
| + 'source_file': '<(PRODUCT_DIR)/ui_base_unittests.app/ui_base_unittests', |
| + 'dest_file': '<(PRODUCT_DIR)/ui_unittests.app/ui_unittests', |
| + }, |
| + }, |
| + ], |
| + ], |
| + 'inputs': [ |
| + '../../build/cp.py', |
| + '<(source_file)', |
| + ], |
| + 'outputs': [ |
| + '<(dest_file)', |
| + ], |
| + 'action': [ |
| + 'python', '../../build/cp.py', '<(source_file)', '<(dest_file)', |
| + ], |
| + }, |
| + ], |
| + }, |
| ], |
| 'conditions': [ |
| # Mac target to build a test Framework bundle to mock out resource loading. |
| @@ -251,16 +289,45 @@ |
| ['OS == "android"', { |
| 'targets': [ |
| { |
| - 'target_name': 'ui_unittests_apk', |
| + 'target_name': 'ui_base_unittests_apk', |
| 'type': 'none', |
| 'dependencies': [ |
| - 'ui_unittests', |
| + 'ui_base_unittests', |
| ], |
| 'variables': { |
| - 'test_suite_name': 'ui_unittests', |
| + 'test_suite_name': 'ui_base_unittests', |
| }, |
| 'includes': [ '../../build/apk_test.gypi' ], |
| }, |
| + { |
| + # TODO(tfarina): Remove this target after all traces of it are updated |
| + # to point to ui_base_unittests_apk. crbug.com/331829 |
| + 'target_name': 'ui_unittests_apk', |
| + 'type': 'none', |
| + 'dependencies': [ |
| + 'ui_base_unittests_apk', |
| + ], |
| + 'actions': [ |
| + { |
| + 'message': 'TEMPORARY: Copying ui_base_unittests_apk to ui_unittests_apk', |
| + 'action_name': 'copy_ui_base_unittests_apk', |
| + 'variables': { |
| + 'source_file': '<(PRODUCT_DIR)/ui_base_unittests_apk/ui_base_unittests-debug.apk', |
| + 'dest_file': '<(PRODUCT_DIR)/ui_unittests/ui_unittests-debug.pak', |
| + }, |
| + 'inputs': [ |
| + '../../build/cp.py', |
| + '<(source_file)', |
| + ], |
| + 'outputs': [ |
| + '<(dest_file)', |
| + ], |
| + 'action': [ |
| + 'python', '../../build/cp.py', '<(source_file)', '<(dest_file)', |
| + ], |
| + }, |
| + ], |
| + }, |
| ], |
| }], |
| ], |