Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: tools/gn/c_include_iterator.cc

Issue 588893006: gn: attach comments to parse tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: x64 Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/header_checker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/c_include_iterator.cc
diff --git a/tools/gn/c_include_iterator.cc b/tools/gn/c_include_iterator.cc
index e87e66e2d6faa38fd85f4ba4b767702a2efeabb3..25eba9d3f7a90470e1622bb174481fa1c261b6fb 100644
--- a/tools/gn/c_include_iterator.cc
+++ b/tools/gn/c_include_iterator.cc
@@ -133,9 +133,14 @@ bool CIncludeIterator::GetNextIncludeString(base::StringPiece* out,
// Only count user includes for now.
*out = include_contents;
*location = LocationRange(
- Location(input_file_, cur_line_number, begin_char),
- Location(input_file_, cur_line_number,
- begin_char + static_cast<int>(include_contents.size())));
+ Location(input_file_,
+ cur_line_number,
+ begin_char,
+ -1 /* TODO(scottmg): Is this important? */),
+ Location(input_file_,
+ cur_line_number,
+ begin_char + static_cast<int>(include_contents.size()),
+ -1 /* TODO(scottmg): Is this important? */));
lines_since_last_include_ = 0;
return true;
« no previous file with comments | « no previous file | tools/gn/header_checker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698