gn: attach comments to parse tree

tools/gn/location.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef TOOLS_GN_LOCATION_H_
 #define TOOLS_GN_LOCATION_H_
 
 #include <string>
 
 class InputFile;
 
 // Represents a place in a source file. Used for error reporting.
 class Location {
  public:
   Location();
-  Location(const InputFile* file, int line_number, int char_offset);
+  Location(const InputFile* file, int line_number, int char_offset, int byte);
 
   const InputFile* file() const { return file_; }
   int line_number() const { return line_number_; }
   int char_offset() const { return char_offset_; }
+  int byte() const { return byte_; }
 
   bool operator==(const Location& other) const;
   bool operator!=(const Location& other) const;
   bool operator<(const Location& other) const;
 
   // Returns a string with the file, line, and (optionally) the character
   // offset for this location. If this location is null, returns an empty
   // string.
   std::string Describe(bool include_char_offset) const;
 
  private:
   const InputFile* file_;  // Null when unset.
   int line_number_;  // -1 when unset.

[brettw, 2014/09/23 21:33:15]

Cay you document that the line and char offset are 1-based (my fault for not
doing this earlier)? I assume your byte is 0-based, so that should be mentioned
as well.

[scottmg, 2014/09/23 22:15:37]

Done.

   int char_offset_;  // -1 when unset.
+  int byte_;
 };
 
 // Represents a range in a source file. Used for error reporting.
 // The end is exclusive i.e. [begin, end)
 class LocationRange {
  public:
   LocationRange();
   LocationRange(const Location& begin, const Location& end);
 
   const Location& begin() const { return begin_; }
   const Location& end() const { return end_; }
 
   LocationRange Union(const LocationRange& other) const;
 
  private:
   Location begin_;
   Location end_;
 };
 
 #endif  // TOOLS_GN_LOCATION_H_