Disables the maximize button for an app window with a maximum size and a custom frame color

Disables the maximize button for an app window with a maximum size and a custom frame color

BUG=416214
TEST=Manual, see bug

Committed: https://crrev.com/b1400bfbfb079bf3dfeb9de9d58f651059f98e1b
Cr-Commit-Position: refs/heads/master@{#295922}

[pkotwicz, 2014-09-20 20:19:36]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2014-09-20 20:28:50]

pkotwicz@chromium.org changed reviewers:
+ jackhou@chromium.org

[pkotwicz, 2014-09-20 20:28:51]

jackhou@ can you please take a look?

I believe that the current behavior was introduced in crbug.com/158868

I am unsure whether it would be preferable to hide the maximize button when
maximize is disabled. This is what CustomFrameView does.

[jackhou1, 2014-09-21 00:10:09]

On 2014/09/20 20:28:51, pkotwicz wrote:
> jackhou@ can you please take a look?
> 
> I believe that the current behavior was introduced in crbug.com/158868
> 
> I am unsure whether it would be preferable to hide the maximize button when
> maximize is disabled. This is what CustomFrameView does.

lgtm

app_window_frame_view is used for colored frames on windows right? I think it's
fine just to disable it. That will ultimately be what happens with native frames
on Windows.

[pkotwicz, 2014-09-21 14:58:00]

pkotwicz@chromium.org changed reviewers:
+ tapted@chromium.org

[pkotwicz, 2014-09-21 14:58:01]

tapted@ for OWNERs

jackhou@: We sometimes use CustomFrameView for apps on Windows. It would be nice
to have consistency between CustomFrameView and AppWindowFrameView

[tapted, 2014-09-21 23:43:28]

lgtm

[pkotwicz, 2014-09-21 23:57:11]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-09-21 23:58:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588873002/20001

[commit-bot: I haz the power, 2014-09-22 01:09:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-22 01:09:17]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pkotwicz, 2014-09-22 01:38:49]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-09-22 01:39:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588873002/20001

[pkotwicz, 2014-09-22 01:43:44]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-09-22 01:45:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588873002/40001

[commit-bot: I haz the power, 2014-09-22 02:12:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-22 02:12:24]

Try jobs failed on following builders:
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[pkotwicz, 2014-09-22 03:34:14]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-09-22 03:35:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588873002/40001

[commit-bot: I haz the power, 2014-09-22 04:14:06]

Committed patchset #2 (id:40001) as 4dcc6bf7773a561354fb59e024c43aea5474b9b2

[commit-bot: I haz the power, 2014-09-22 04:14:39]

Patchset 2 (id:??) landed as
https://crrev.com/b1400bfbfb079bf3dfeb9de9d58f651059f98e1b
Cr-Commit-Position: refs/heads/master@{#295922}