Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 588853002: Revert of Souped-up SkTextBlob. (Closed)

Created:
6 years, 3 months ago by f(malita)
Modified:
6 years, 3 months ago
CC:
reviews_skia.org, jbroman
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Souped-up SkTextBlob. (patchset #3 id:40001 of https://codereview.chromium.org/581173003/) Reason for revert: Broke the new blobshader gm. Original issue's description: > Souped-up SkTextBlob. > > Refactored text blob backend for improved performance: instead of using > separate buffers for runs/positions/glyphs, everything is now packed in > a consolidated slab (including the SkTextBlob object itself!). > > Benefits: > > * number of allocations per blob construction reduced from ~4 to 1 > (also minimizes internal fragmentation) > * run record size reduced by 8 bytes > > This takes the blob construction overhead down to negligible levels > (for the current Blink uncached textblob implementation). > > Unfortunately, the code is much more finicky (run merging in > particular) -- hence the assert spree. > > Multi-run blobs are vulnerable to realloc storms but this is not a > problem at the moment because Blink is using one-run blobs 99% of the > time. Will be addressed in the future. > > > R=reed@google.com,mtklein@google.com,robertphillips@google.com > > Committed: https://skia.googlesource.com/skia/+/13645ea0ea87038ebd71be3bd6d53b313069a9e4 TBR=mtklein@google.com,reed@google.com,robertphillips@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/e50215e5988c3b29c3e337fdd7cc3c9b13cec013

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -283 lines) Patch
M include/core/SkTextBlob.h View 5 chunks +31 lines, -27 lines 0 comments Download
M src/core/SkTextBlob.cpp View 7 chunks +103 lines, -256 lines 0 comments Download
M tests/TextBlobTest.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
f(malita)
Created Revert of Souped-up SkTextBlob.
6 years, 3 months ago (2014-09-20 02:02:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588853002/1
6 years, 3 months ago (2014-09-20 02:03:02 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 02:03:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as e50215e5988c3b29c3e337fdd7cc3c9b13cec013

Powered by Google App Engine
This is Rietveld 408576698