Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 588843002: Fix jank caused by infobars appearing. (Closed)

Created:
6 years, 3 months ago by newt (away)
Modified:
6 years, 3 months ago
Reviewers:
jdduke (slow), gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix jank caused by infobars appearing. When the InfoBarContainer is first attached to the window, View.initialAwakenScrollBars() is called on it. Even though the scrollbars aren't visible, this schedules a delayed runnable to fade out the scrollbars 1.2 seconds later. This delayed runnable (View$ScrollabilityCache) then calls View.invalidate() repeatedly as it fades out the (already invisible) scrollbar, which pauses scroll updates and touch event handling for 10 to 15 frames. This CL disables the scrollbars on the InfoBarContainer, except in the rare case that the container is actually scrollable (i.e. when infobars take up the entire screen). In that case, page jank doesn't matter since the user can't even see the webpage! BUG=407149 NOTRY=true Committed: https://crrev.com/7cca8293771e68026262d05cd7c13620d8a79a3f Cr-Commit-Position: refs/heads/master@{#295849}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
newt (away)
PTAL
6 years, 3 months ago (2014-09-20 01:00:19 UTC) #2
gone
lgtm
6 years, 3 months ago (2014-09-20 01:21:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588843002/1
6 years, 3 months ago (2014-09-20 01:31:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588843002/1
6 years, 3 months ago (2014-09-20 01:31:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588843002/1
6 years, 3 months ago (2014-09-20 02:37:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as d79f915472ca973851ea184ad32dc4191fccbfd1
6 years, 3 months ago (2014-09-20 02:38:26 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7cca8293771e68026262d05cd7c13620d8a79a3f Cr-Commit-Position: refs/heads/master@{#295849}
6 years, 3 months ago (2014-09-20 02:39:01 UTC) #11
jdduke (slow)
6 years, 3 months ago (2014-09-20 02:54:37 UTC) #12
Message was sent while issue was closed.
Yay, lgtm!

Powered by Google App Engine
This is Rietveld 408576698