Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3276)

Unified Diff: chrome/common/service_process_util_unittest.cc

Issue 588833002: mac: Fix launchd test on 10.10 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments from thestig. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/service_process_util_unittest.cc
diff --git a/chrome/common/service_process_util_unittest.cc b/chrome/common/service_process_util_unittest.cc
index 0ae845935bdf8e84176863d66d693edae505e16d..8133011d360f765b255896eea0eb1521b105086a 100644
--- a/chrome/common/service_process_util_unittest.cc
+++ b/chrome/common/service_process_util_unittest.cc
@@ -345,10 +345,13 @@ TEST_F(ServiceProcessStateFileManipulationTest, VerifyLaunchD) {
// on Mac and "launch_msg(): Socket is not connected" appears.
// This test is designed to make sure that launchd is working.
// http://crbug/75518
+ // Note: This particular problem no longer affects launchd in 10.10+, since
+ // there is no user owned launchd process and sockets are no longer made at
+ // /tmp/launchd*/sock. This test is still useful as a sanity check to make
+ // sure that launchd appears to be working.
CommandLine cl(base::FilePath("/bin/launchctl"));
- cl.AppendArg("list");
- cl.AppendArg("com.apple.launchctl.Aqua");
+ cl.AppendArg("limit");
std::string output;
int exit_code = -1;
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698