Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 58883002: Nit: Using GetWidget() here is pretty confusing given that all methods (Closed)

Created:
7 years, 1 month ago by mlamouri (slow - plz ping)
Modified:
7 years, 1 month ago
Reviewers:
benwells
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Nit: Using GetWidget() here is pretty confusing given that all methods around directly use window_ and GetWidget() would simply return window_. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233443

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments applied #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/views/apps/native_app_window_views.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
mlamouri (slow - plz ping)
It's pretty trivial but better to not have all developers doing like me and check ...
7 years, 1 month ago (2013-11-05 04:11:35 UTC) #1
benwells
super nit, use Bug=None https://codereview.chromium.org/58883002/diff/1/chrome/browser/ui/views/apps/native_app_window_views.cc File chrome/browser/ui/views/apps/native_app_window_views.cc (right): https://codereview.chromium.org/58883002/diff/1/chrome/browser/ui/views/apps/native_app_window_views.cc#newcode290 chrome/browser/ui/views/apps/native_app_window_views.cc:290: return views::HWNDForWidget(GetWidget()->GetTopLevelWidget()); For consistency may ...
7 years, 1 month ago (2013-11-05 11:29:07 UTC) #2
mlamouri (slow - plz ping)
New patch with review comments applied.
7 years, 1 month ago (2013-11-05 23:59:07 UTC) #3
benwells
lgtm, but please update description to have BUG=None
7 years, 1 month ago (2013-11-06 01:41:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/58883002/60001
7 years, 1 month ago (2013-11-06 01:51:29 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94519
7 years, 1 month ago (2013-11-06 06:18:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/58883002/60001
7 years, 1 month ago (2013-11-06 06:46:45 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94681
7 years, 1 month ago (2013-11-06 10:00:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/58883002/60001
7 years, 1 month ago (2013-11-06 10:50:01 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94811
7 years, 1 month ago (2013-11-06 14:09:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/58883002/60001
7 years, 1 month ago (2013-11-06 22:24:34 UTC) #11
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 00:50:45 UTC) #12
Message was sent while issue was closed.
Change committed as 233443

Powered by Google App Engine
This is Rietveld 408576698