tools/gn/c_include_iterator.cc - Issue 588813002: gn: beginnings of format command

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/c_include_iterator.cc

Issue 588813002: gn: beginnings of format command (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: handle line comments at eof Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/c_include_iterator.cc

diff --git a/tools/gn/c_include_iterator.cc b/tools/gn/c_include_iterator.cc

index e87e66e2d6faa38fd85f4ba4b767702a2efeabb3..1458bf6fbfd1f65ce3cdc79ecdf76ce9625c6d2f 100644

--- a/tools/gn/c_include_iterator.cc

+++ b/tools/gn/c_include_iterator.cc

@@ -133,9 +133,12 @@ bool CIncludeIterator::GetNextIncludeString(base::StringPiece* out,

// Only count user includes for now.

*out = include_contents;

*location = LocationRange(

- Location(input_file_, cur_line_number, begin_char),

- Location(input_file_, cur_line_number,

- begin_char + static_cast<int>(include_contents.size())));

+ Location(

+ input_file_, cur_line_number, begin_char, -1 /* TODO(scottmg) */),

+ Location(input_file_,

+ cur_line_number,

+ begin_char + static_cast<int>(include_contents.size()),

+ -1 /* TODO(scottmg) */));

lines_since_last_include_ = 0;

return true;

« no previous file with comments | « tools/gn/BUILD.gn ('k') | tools/gn/command_format.cc » ('j') | no next file with comments »