Compile print_preview, part 4: reduce down to 140 errors

Compile print_preview, part 4: reduce down to 140 errors

R=alekseys@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/print_preview/compiled_resources.gyp && ninja -C out/Default

Committed: https://crrev.com/0346d2fe3baeb218b91ab3f39ffbd0ccfa075722
Cr-Commit-Position: refs/heads/master@{#297588}

[Vitaly Pavlenko, 2014-09-22 17:23:43]

On 2014/09/19 22:15:12, Vitaly Pavlenko wrote:

ping alekseys@

[Aleksey Shlyapnikov, 2014-09-22 21:44:03]

lgtm

[Dan Beam, 2014-09-29 22:10:05]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2014-09-29 22:10:06]

https://codereview.chromium.org/588753002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/print_preview/previewarea/preview_area.js (right):

https://codereview.chromium.org/588753002/diff/20001/chrome/browser/resources...
chrome/browser/resources/print_preview/previewarea/preview_area.js:34: *        
   zoomOut: Function}}
where is this code?  why not @externs?

https://codereview.chromium.org/588753002/diff/20001/chrome/browser/resources...
chrome/browser/resources/print_preview/previewarea/preview_area.js:435: /**
@type {print_preview.PDFPlugin|Object} */
why |Object?

[Vitaly Pavlenko, 2014-10-01 00:57:44]

https://chromiumcodereview.appspot.com/588753002/diff/20001/chrome/browser/re...
File chrome/browser/resources/print_preview/previewarea/preview_area.js (right):

https://chromiumcodereview.appspot.com/588753002/diff/20001/chrome/browser/re...
chrome/browser/resources/print_preview/previewarea/preview_area.js:34: *        
   zoomOut: Function}}
On 2014/09/29 22:10:06, Dan Beam wrote:
> where is this code?  why not @externs?

These methods are dispatched by C++ code:

https://code.google.com/p/chromium/codesearch#chromium/src/pdf/instance.cc&sq...

For other places we used @typedef. Why do you think we need to use externs here?

https://chromiumcodereview.appspot.com/588753002/diff/20001/chrome/browser/re...
chrome/browser/resources/print_preview/previewarea/preview_area.js:435: /**
@type {print_preview.PDFPlugin|Object} */
On 2014/09/29 22:10:06, Dan Beam wrote:
> why |Object?

Sorry, removed.

[Dan Beam, 2014-10-01 01:11:31]

https://chromiumcodereview.appspot.com/588753002/diff/20001/chrome/browser/re...
File chrome/browser/resources/print_preview/previewarea/preview_area.js (right):

https://chromiumcodereview.appspot.com/588753002/diff/20001/chrome/browser/re...
chrome/browser/resources/print_preview/previewarea/preview_area.js:34: *        
   zoomOut: Function}}
On 2014/10/01 00:57:44, Vitaly Pavlenko wrote:
> On 2014/09/29 22:10:06, Dan Beam wrote:
> > where is this code?  why not @externs?
> 
> These methods are dispatched by C++ code:
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/pdf/instance.cc&sq...
> 
> For other places we used @typedef. Why do you think we need to use externs
here?

because this is basically a complex, static class

[Dan Beam, 2014-10-01 01:20:54]

lgtm

https://chromiumcodereview.appspot.com/588753002/diff/20001/chrome/browser/re...
File chrome/browser/resources/print_preview/previewarea/preview_area.js (right):

https://chromiumcodereview.appspot.com/588753002/diff/20001/chrome/browser/re...
chrome/browser/resources/print_preview/previewarea/preview_area.js:34: *        
   zoomOut: Function}}
On 2014/10/01 01:11:31, Dan Beam wrote:
> On 2014/10/01 00:57:44, Vitaly Pavlenko wrote:
> > On 2014/09/29 22:10:06, Dan Beam wrote:
> > > where is this code?  why not @externs?
> > 
> > These methods are dispatched by C++ code:
> > 
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/pdf/instance.cc&sq...
> > 
> > For other places we used @typedef. Why do you think we need to use externs
> here?
> 
> because this is basically a complex, static class

in looking at the class, keeping @externs up to date would kind of suck.  choose
your poison.

[Vitaly Pavlenko, 2014-10-01 02:01:33]

The CQ bit was checked by vitalyp@chromium.org

[commit-bot: I haz the power, 2014-10-01 02:02:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588753002/40001

[commit-bot: I haz the power, 2014-10-01 02:52:42]

Committed patchset #3 (id:40001) as e5bd2cc1a4d95f5d36b34f4b95e8de83fbbb9b3c

[commit-bot: I haz the power, 2014-10-01 02:53:47]

Patchset 3 (id:??) landed as
https://crrev.com/0346d2fe3baeb218b91ab3f39ffbd0ccfa075722
Cr-Commit-Position: refs/heads/master@{#297588}