Copy edit SDK section.

Copy edit SDK section.

BUG=none
R=
TEST=none
NOTRY=true
(documentation only change)

Committed: https://crrev.com/c3e44d6a8d69d8870b5bdc0d71ffe71891c97148
Cr-Commit-Position: refs/heads/master@{#296033}

[jpmedley, 2014-09-19 21:35:57]

jmedley@chromium.org changed reviewers:
+ jfb@chromium.org, mkearney@chromium.org, smain@chromium.org

[JF, 2014-09-22 16:20:34]

jfb@chromium.org changed reviewers:
+ binji@chromium.org

[JF, 2014-09-22 16:20:34]

Looks good overall, though I had a few questions. Adding binji, who's more
competent than I am at SDK things :-)

https://codereview.chromium.org/588723002/diff/1/native_client_sdk/src/doc/sd...
File native_client_sdk/src/doc/sdk/download.rst (right):

https://codereview.chromium.org/588723002/diff/1/native_client_sdk/src/doc/sd...
native_client_sdk/src/doc/sdk/download.rst:43: Python 2.6 or 2.7
DO you think it's worth saying that 2.7 is the latest 2.x Python version? If 2.8
comes out we'd be fine with that too.

https://codereview.chromium.org/588723002/diff/1/native_client_sdk/src/doc/sd...
native_client_sdk/src/doc/sdk/download.rst:73:
<https://github.com/kennethreitz/osx-gcc-installer>`_.
Would it be worth adding instructions to install ``make`` on Windows and Linux?
On Linux it seems like the developer could figure it out, but Windows should we
recommend cygwin, or something else?

https://codereview.chromium.org/588723002/diff/1/native_client_sdk/src/doc/sd...
native_client_sdk/src/doc/sdk/download.rst:153: Chrome 31, Chrome 32, etc..
Missing an extra period on the ellipsis..

https://codereview.chromium.org/588723002/diff/1/native_client_sdk/src/doc/sd...
File native_client_sdk/src/doc/sdk/examples.rst (right):

https://codereview.chromium.org/588723002/diff/1/native_client_sdk/src/doc/sd...
native_client_sdk/src/doc/sdk/examples.rst:117: ...
Does it also build pexes?

In general we're trying to nudge users towards PNaCl instead of NaCl. Do you
think the documentation should avoid talking about the ``make`` option, and
instead talk about ``make TOOLCHAIN=pnacl`` first? Or do you think the
toolchain's ``make`` default should be PNaCl also/instead?

[Sam Clegg, 2014-09-22 17:25:10]

sbc@chromium.org changed reviewers:
+ sbc@chromium.org

[Sam Clegg, 2014-09-22 17:25:11]

https://codereview.chromium.org/588723002/diff/1/native_client_sdk/src/doc/sd...
File native_client_sdk/src/doc/sdk/download.rst (right):

https://codereview.chromium.org/588723002/diff/1/native_client_sdk/src/doc/sd...
native_client_sdk/src/doc/sdk/download.rst:43: Python 2.6 or 2.7
On 2014/09/22 16:20:34, JF wrote:
> DO you think it's worth saying that 2.7 is the latest 2.x Python version? If
2.8
> comes out we'd be fine with that too.

We've already started using pythonn2.7 features (at least in naclports and
native_client internals), so I suggest we require 2.7 here.  Its simpler.

Also, according to the python community there never will be a 2.8.

[binji, 2014-09-22 17:29:57]

pnacl should be the default already. It's a regression that it isn't currently,
I'll fix it.

https://codereview.chromium.org/588723002/diff/1/native_client_sdk/src/doc/sd...
File native_client_sdk/src/doc/sdk/download.rst (right):

https://codereview.chromium.org/588723002/diff/1/native_client_sdk/src/doc/sd...
native_client_sdk/src/doc/sdk/download.rst:73:
<https://github.com/kennethreitz/osx-gcc-installer>`_.
On 2014/09/22 16:20:34, JF wrote:
> Would it be worth adding instructions to install ``make`` on Windows and
Linux?
> On Linux it seems like the developer could figure it out, but Windows should
we
> recommend cygwin, or something else?

We include a copy of GNU make with the SDK on Windows.

[jpmedley, 2014-09-22 19:51:30]

PTAL

https://codereview.chromium.org/588723002/diff/1/native_client_sdk/src/doc/sd...
File native_client_sdk/src/doc/sdk/download.rst (right):

https://codereview.chromium.org/588723002/diff/1/native_client_sdk/src/doc/sd...
native_client_sdk/src/doc/sdk/download.rst:43: Python 2.6 or 2.7
On 2014/09/22 17:25:10, Sam Clegg wrote:
> On 2014/09/22 16:20:34, JF wrote:
> > DO you think it's worth saying that 2.7 is the latest 2.x Python version? If
> 2.8
> > comes out we'd be fine with that too.
> 
> We've already started using pythonn2.7 features (at least in naclports and
> native_client internals), so I suggest we require 2.7 here.  Its simpler.
> 
> Also, according to the python community there never will be a 2.8.

Done.

https://codereview.chromium.org/588723002/diff/1/native_client_sdk/src/doc/sd...
native_client_sdk/src/doc/sdk/download.rst:73:
<https://github.com/kennethreitz/osx-gcc-installer>`_.
On 2014/09/22 17:29:57, binji wrote:
> On 2014/09/22 16:20:34, JF wrote:
> > Would it be worth adding instructions to install ``make`` on Windows and
> Linux?
> > On Linux it seems like the developer could figure it out, but Windows should
> we
> > recommend cygwin, or something else?
> 
> We include a copy of GNU make with the SDK on Windows.

Done.

https://codereview.chromium.org/588723002/diff/1/native_client_sdk/src/doc/sd...
native_client_sdk/src/doc/sdk/download.rst:153: Chrome 31, Chrome 32, etc..
On 2014/09/22 16:20:34, JF wrote:
> Missing an extra period on the ellipsis..

It's not an ellipse. The abbreviation gets a period. Then I have to add a period
to end the sentence. It looks weird, but it's correct.

https://codereview.chromium.org/588723002/diff/1/native_client_sdk/src/doc/sd...
File native_client_sdk/src/doc/sdk/examples.rst (right):

https://codereview.chromium.org/588723002/diff/1/native_client_sdk/src/doc/sd...
native_client_sdk/src/doc/sdk/examples.rst:117: ...
On 2014/09/22 16:20:34, JF wrote:
> Does it also build pexes?
> 
> In general we're trying to nudge users towards PNaCl instead of NaCl. Do you
> think the documentation should avoid talking about the ``make`` option, and
> instead talk about ``make TOOLCHAIN=pnacl`` first? Or do you think the
> toolchain's ``make`` default should be PNaCl also/instead?

When the toolchain defaults get changed, I'll update the examples. Unless the
turnaround on that is lightning fast, I'd prefer not to hold up this CL.

[JF, 2014-09-22 20:02:57]

lgtm

https://codereview.chromium.org/588723002/diff/1/native_client_sdk/src/doc/sd...
File native_client_sdk/src/doc/sdk/download.rst (right):

https://codereview.chromium.org/588723002/diff/1/native_client_sdk/src/doc/sd...
native_client_sdk/src/doc/sdk/download.rst:153: Chrome 31, Chrome 32, etc..
On 2014/09/22 19:51:29, jmedley wrote:
> On 2014/09/22 16:20:34, JF wrote:
> > Missing an extra period on the ellipsis..
> 
> It's not an ellipse. The abbreviation gets a period. Then I have to add a
period
> to end the sentence. It looks weird, but it's correct.

Ha, I'd never seen that before :)

https://codereview.chromium.org/588723002/diff/1/native_client_sdk/src/doc/sd...
File native_client_sdk/src/doc/sdk/examples.rst (right):

https://codereview.chromium.org/588723002/diff/1/native_client_sdk/src/doc/sd...
native_client_sdk/src/doc/sdk/examples.rst:117: ...
On 2014/09/22 19:51:29, jmedley wrote:
> On 2014/09/22 16:20:34, JF wrote:
> > Does it also build pexes?
> > 
> > In general we're trying to nudge users towards PNaCl instead of NaCl. Do you
> > think the documentation should avoid talking about the ``make`` option, and
> > instead talk about ``make TOOLCHAIN=pnacl`` first? Or do you think the
> > toolchain's ``make`` default should be PNaCl also/instead?
> 
> When the toolchain defaults get changed, I'll update the examples. Unless the
> turnaround on that is lightning fast, I'd prefer not to hold up this CL.

Sounds good, could you leave a TODO comment in the documentation?

https://codereview.chromium.org/588723002/diff/20001/native_client_sdk/src/do...
File native_client_sdk/src/doc/sdk/download.rst (right):

https://codereview.chromium.org/588723002/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/sdk/download.rst:41: .. _python26-27:
This should probably be updated to _python_prereq or something (and the uses of
it).

[jpmedley, 2014-09-22 20:20:34]

The CQ bit was checked by jmedley@chromium.org

[commit-bot: I haz the power, 2014-09-22 20:21:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588723002/40001

[commit-bot: I haz the power, 2014-09-22 20:22:32]

Committed patchset #3 (id:40001) as 39c27f4a00fea36f5125dd2cacaca6b4f83b30f1

[commit-bot: I haz the power, 2014-09-22 20:23:13]

Patchset 3 (id:??) landed as
https://crrev.com/c3e44d6a8d69d8870b5bdc0d71ffe71891c97148
Cr-Commit-Position: refs/heads/master@{#296033}