Compile print_preview, part 3: reduce down to 185 errors

chrome/browser/resources/print_preview/settings/media_size_settings.js

Index: chrome/browser/resources/print_preview/settings/media_size_settings.js
diff --git a/chrome/browser/resources/print_preview/settings/media_size_settings.js b/chrome/browser/resources/print_preview/settings/media_size_settings.js
index 9f2d46e907ff4aecd6bc4d8fad3d9bd191a2e0b8..be730721a53b357d5d20fb3b5054e7f921697a36 100644
--- a/chrome/browser/resources/print_preview/settings/media_size_settings.js
+++ b/chrome/browser/resources/print_preview/settings/media_size_settings.js
@@ -81,10 +81,12 @@ cr.define('print_preview', function() {
           var selectOption = document.createElement('option');
           var displayName = option.custom_display_name;
           if (!displayName && option.custom_display_name_localized) {
-            var getLocaleToCompare = function(locale, languageOnly) {
-              var code = languageOnly ? locale.split('-')[0] : locale;
+            var getLocaleToCompare =
+                /** @type {function(string, boolean=): string} */

[Dan Beam, 2014/09/29 18:42:00]

what is the point of this cast?

[Vitaly Pavlenko, 2014/10/01 00:33:37]

Otherwise at line 93 we get the following error:

##
/usr/local/google/home/vitalyp/src/chrome/browser/resources/print_preview/settings/media_size_settings.js:93:
ERROR - Function getLocaleToCompare: called with 1 argument(s). Function
requires at least 2 argument(s) and no more than 2 argument(s).
##                 if (getLocaleToCompare(items[i].locale) == locale)
##                     ^

+                (function(locale, opt_languageOnly) {
+              var code = opt_languageOnly ? locale.split('-')[0] : locale;
               return code.toLowerCase();
-            };
+            });
             var getItemForLocale = function(items, locale, languageOnly) {
               locale = getLocaleToCompare(locale, languageOnly);
               for (var i = 0; i < items.length; i++) {
@@ -100,7 +102,7 @@ cr.define('print_preview', function() {
           }
           selectOption.text = displayName || option.name;
           selectOption.value = JSON.stringify(option);
-          select.add(selectOption);
+          select.appendChild(selectOption);
           if (option.is_default) {
             indexToSelect = index;
           }