chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js - Issue 588713002: Compile print_preview, part 3: reduce down to 185 errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js

Issue 588713002: Compile print_preview, part 3: reduce down to 185 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@I_print_preview_2

Patch Set: revert movement of enums: now handle in compiler pass Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/print_preview/print_preview.js ('K') | « chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js ('k') | chrome/browser/resources/print_preview/settings/copies_settings.js » ('j') | chrome/browser/resources/print_preview/settings/media_size_settings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js

diff --git a/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js b/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js

index 45ced099b613c8c7ffa9590831238363f1ad7514..71cff811f59e24337d960f242fa8948ee5468d0a 100644

--- a/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js

+++ b/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js

@@ -255,7 +255,7 @@ cr.define('print_preview', function() {

item.value = option.value;

if (option.is_default)

indexToSelect = index;

- selectEl.add(item);

Dan Beam 2014/09/29 18:42:00 how did this work?

Vitaly Pavlenko 2014/10/01 00:33:37 As I understand, HTMLSelectElement.prototype.add()

+ selectEl.appendChild(item);

});

for (var i = 0, option; option = selectEl.options[i]; i++) {

if (option.value == this.selectedValue_) {