chrome/browser/resources/print_preview/search/destination_list_item.js - Issue 588713002: Compile print_preview, part 3: reduce down to 185 errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/search/destination_list_item.js

Issue 588713002: Compile print_preview, part 3: reduce down to 185 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@I_print_preview_2

Patch Set: fixed comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/print_preview_utils.js ('k') | chrome/browser/resources/print_preview/search/destination_search.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/search/destination_list_item.js

diff --git a/chrome/browser/resources/print_preview/search/destination_list_item.js b/chrome/browser/resources/print_preview/search/destination_list_item.js

index 9f843ee0288191b2626bbc01bcff4b65a18c8575..66a18ce10bf2367bd8c7b28806c6f90e98286536 100644

--- a/chrome/browser/resources/print_preview/search/destination_list_item.js

+++ b/chrome/browser/resources/print_preview/search/destination_list_item.js

@@ -11,11 +11,11 @@ cr.define('print_preview', function() {

* events to.

* @param {!print_preview.Destination} destination Destination data object to

* render.

- * @param {RegExp} query Active filter query.

+ * @param {RegExp=} opt_query Active filter query.

* @constructor

* @extends {print_preview.Component}

- function DestinationListItem(eventTarget, destination, query) {

+ function DestinationListItem(eventTarget, destination, opt_query) {

print_preview.Component.call(this);

/**

@@ -34,10 +34,10 @@ cr.define('print_preview', function() {

/**

* Active filter query text.

- * @type {RegExp}

+ * @type {?RegExp}

Aleksey Shlyapnikov 2014/09/22 23:25:13 RegExp is an object and it's not typedefed, right?

Vitaly Pavlenko 2014/09/23 00:11:30 Oh, I was confused with @typedef stuff. You're rig

* @private

- this.query_ = query;

+ this.query_ = opt_query || null;

/**

* FedEx terms-of-service widget or {@code null} if this list item does not