chrome/browser/resources/print_preview/settings/more_settings.js - Issue 588713002: Compile print_preview, part 3: reduce down to 185 errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/settings/more_settings.js

Issue 588713002: Compile print_preview, part 3: reduce down to 185 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@I_print_preview_2

Patch Set: fix assert Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/settings/media_size_settings.js ('k') | ui/webui/resources/js/cr/event_target.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/settings/more_settings.js

diff --git a/chrome/browser/resources/print_preview/settings/more_settings.js b/chrome/browser/resources/print_preview/settings/more_settings.js

index 8a3d5f6fd2f6f490a9a84c8b35b628a636f04870..580b56ae5abf9d32d8f12fa4223e1f00685ac5f5 100644

--- a/chrome/browser/resources/print_preview/settings/more_settings.js

+++ b/chrome/browser/resources/print_preview/settings/more_settings.js

@@ -123,7 +123,7 @@ cr.define('print_preview', function() {

updateState_: function(noAnimation) {

if (!this.firstDestinationReady_) {

- fadeOutElement(this.getElement(), noAnimation);

+ fadeOutElement(this.getElement());

return;

}

// When capabilities are not known yet, don't change the state to avoid

@@ -154,7 +154,7 @@ cr.define('print_preview', function() {

if (hasSectionsToToggle)

fadeInElement(this.getElement(), noAnimation);

else

- fadeOutElement(this.getElement(), noAnimation);

+ fadeOutElement(this.getElement());

var collapseContent =

this.settingsToShow_ == MoreSettings.SettingsToShow.MOST_POPULAR &&

« no previous file with comments | « chrome/browser/resources/print_preview/settings/media_size_settings.js ('k') | ui/webui/resources/js/cr/event_target.js » ('j') | no next file with comments »