chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js - Issue 588713002: Compile print_preview, part 3: reduce down to 185 errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js

Issue 588713002: Compile print_preview, part 3: reduce down to 185 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@I_print_preview_2

Patch Set: fix assert Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/search/destination_search.js ('k') | chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js

diff --git a/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js b/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js

index 9b6bc9516387c482db3a8ea8a6e058855d72ea58..969b19dc52fd71330d0146666ba98694fdef1693 100644

--- a/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js

+++ b/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js

@@ -123,8 +123,8 @@ cr.define('print_preview', function() {

getAvailableContentHeight_: function() {

var elStyle = window.getComputedStyle(this.getElement());

return this.getElement().offsetHeight -

- parseInt(elStyle.getPropertyValue('padding-top')) -

- parseInt(elStyle.getPropertyValue('padding-bottom')) -

+ parseInt(elStyle.getPropertyValue('padding-top'), 10) -

+ parseInt(elStyle.getPropertyValue('padding-bottom'), 10) -

this.getChildElement('.settings-area').offsetTop -

this.getChildElement('.action-area').offsetHeight;