chrome/browser/resources/print_preview/print_preview_utils.js - Issue 588713002: Compile print_preview, part 3: reduce down to 185 errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/print_preview_utils.js

Issue 588713002: Compile print_preview, part 3: reduce down to 185 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@I_print_preview_2

Patch Set: fix assert Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/print_preview.js ('k') | chrome/browser/resources/print_preview/search/destination_list_item.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/print_preview_utils.js

diff --git a/chrome/browser/resources/print_preview/print_preview_utils.js b/chrome/browser/resources/print_preview/print_preview_utils.js

index 7f39003f9d6db0c653b66201b670790efcc14c06..18740b9dd5ec5a5f90ccaa6cab6356c5f3777f10 100644

--- a/chrome/browser/resources/print_preview/print_preview_utils.js

+++ b/chrome/browser/resources/print_preview/print_preview_utils.js

@@ -145,7 +145,7 @@ function pageRangeTextToPageRanges(pageRangeText, opt_totalPageCount) {

function pageRangeTextToPageList(pageRangeText, totalPageCount) {

var pageRanges = pageRangeTextToPageRanges(pageRangeText, totalPageCount);

- pageList = [];

+ var pageList = [];

if (pageRanges) {

for (var i = 0; i < pageRanges.length; ++i) {

for (var j = pageRanges[i].from; j <= Math.min(pageRanges[i].to,

@@ -172,7 +172,7 @@ function pageListToPageSet(pageList) {

return pageSet;

pageSet = pageList.slice(0);

pageSet.sort(function(a, b) {

- return (/** @type {number} */ a) - (/** @type {number} */ b);

+ return /** @type {number} */(a) - /** @type {number} */(b);

});

pageSet = removeDuplicates(pageSet);

return pageSet;