Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2985)

Unified Diff: chrome/browser/resources/print_preview/settings/media_size_settings.js

Issue 588713002: Compile print_preview, part 3: reduce down to 185 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@I_print_preview_2
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/settings/media_size_settings.js
diff --git a/chrome/browser/resources/print_preview/settings/media_size_settings.js b/chrome/browser/resources/print_preview/settings/media_size_settings.js
index 9f2d46e907ff4aecd6bc4d8fad3d9bd191a2e0b8..be730721a53b357d5d20fb3b5054e7f921697a36 100644
--- a/chrome/browser/resources/print_preview/settings/media_size_settings.js
+++ b/chrome/browser/resources/print_preview/settings/media_size_settings.js
@@ -81,10 +81,12 @@ cr.define('print_preview', function() {
var selectOption = document.createElement('option');
var displayName = option.custom_display_name;
if (!displayName && option.custom_display_name_localized) {
- var getLocaleToCompare = function(locale, languageOnly) {
- var code = languageOnly ? locale.split('-')[0] : locale;
+ var getLocaleToCompare =
+ /** @type {function(string, boolean=): string} */
+ (function(locale, opt_languageOnly) {
+ var code = opt_languageOnly ? locale.split('-')[0] : locale;
return code.toLowerCase();
- };
+ });
var getItemForLocale = function(items, locale, languageOnly) {
locale = getLocaleToCompare(locale, languageOnly);
for (var i = 0; i < items.length; i++) {
@@ -100,7 +102,7 @@ cr.define('print_preview', function() {
}
selectOption.text = displayName || option.name;
selectOption.value = JSON.stringify(option);
- select.add(selectOption);
+ select.appendChild(selectOption);
if (option.is_default) {
indexToSelect = index;
}

Powered by Google App Engine
This is Rietveld 408576698