Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1962)

Unified Diff: chrome/browser/resources/print_preview/data/capabilities_holder.js

Issue 588713002: Compile print_preview, part 3: reduce down to 185 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@I_print_preview_2
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/data/capabilities_holder.js
diff --git a/chrome/browser/resources/print_preview/data/capabilities_holder.js b/chrome/browser/resources/print_preview/data/capabilities_holder.js
index e872f4f0ef32bb090fd8e002d4d03ae9c5d29643..991927e8f27eca959b00a1601243ceb78b1390dc 100644
--- a/chrome/browser/resources/print_preview/data/capabilities_holder.js
+++ b/chrome/browser/resources/print_preview/data/capabilities_holder.js
@@ -12,20 +12,20 @@ cr.define('print_preview', function() {
function CapabilitiesHolder() {
/**
* Reference to the capabilities object.
- * @type {print_preview.Cdd}
+ * @type {?print_preview.Cdd}
Aleksey Shlyapnikov 2014/09/22 22:00:40 I thought objects are nullable by default, why do
Vitaly Pavlenko 2014/09/22 22:33:11 Well, objects are, but typedefed objects aren't: h
* @private
*/
this.capabilities_ = null;
};
CapabilitiesHolder.prototype = {
- /** @return {print_preview.Cdd} The instance held by the holder. */
+ /** @return {?print_preview.Cdd} The instance held by the holder. */
get: function() {
return this.capabilities_;
},
/**
- * @param {!print_preview.Cdd} capabilities New instance to put into the
+ * @param {?print_preview.Cdd} capabilities New instance to put into the
Aleksey Shlyapnikov 2014/09/22 22:00:40 Why did you replace '!' with '?'? The idea was tha
Vitaly Pavlenko 2014/09/22 22:33:11 Sorry about that, reverted.
* holder.
*/
set: function(capabilities) {

Powered by Google App Engine
This is Rietveld 408576698