Compile print_preview, part 3: reduce down to 185 errors

chrome/browser/resources/print_preview/settings/media_size_settings.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   'use strict';
 
   /**
    * Encapsulates all settings and logic related to the media size selection UI.
    * @param {!print_preview.ticket_items.MediaSize} ticketItem Used to read and
@@ skipping 63 matching lines @@
             return select.options[index].value == JSON.stringify(option);
           });
       var indexToSelect = select.selectedIndex;
       if (!sameContent) {
         select.innerHTML = '';
         // TODO: Better heuristics for the display name and options grouping.
         this.ticketItem_.capability.option.forEach(function(option, index) {
           var selectOption = document.createElement('option');
           var displayName = option.custom_display_name;
           if (!displayName && option.custom_display_name_localized) {
-            var getLocaleToCompare = function(locale, languageOnly) {
-              var code = languageOnly ? locale.split('-')[0] : locale;
+            var getLocaleToCompare =
+                /** @type {function(string, boolean=): string} */

[Dan Beam, 2014/09/29 18:42:00]

what is the point of this cast?

[Vitaly Pavlenko, 2014/10/01 00:33:37]

Otherwise at line 93 we get the following error:

##
/usr/local/google/home/vitalyp/src/chrome/browser/resources/print_preview/settings/media_size_settings.js:93:
ERROR - Function getLocaleToCompare: called with 1 argument(s). Function
requires at least 2 argument(s) and no more than 2 argument(s).
##                 if (getLocaleToCompare(items[i].locale) == locale)
##                     ^

+                (function(locale, opt_languageOnly) {
+              var code = opt_languageOnly ? locale.split('-')[0] : locale;
               return code.toLowerCase();
-            };
+            });
             var getItemForLocale = function(items, locale, languageOnly) {
               locale = getLocaleToCompare(locale, languageOnly);
               for (var i = 0; i < items.length; i++) {
                 if (getLocaleToCompare(items[i].locale) == locale)
                   return items[i].value;
               }
               return '';
             };
             var items = option.custom_display_name_localized;
             displayName =
                 getItemForLocale(items, navigator.language, false) ||
                 getItemForLocale(items, navigator.language, true);
           }
           selectOption.text = displayName || option.name;
           selectOption.value = JSON.stringify(option);
-          select.add(selectOption);
+          select.appendChild(selectOption);
           if (option.is_default) {
             indexToSelect = index;
           }
         });
       }
       // Try to select current ticket item.
       var valueToSelect = JSON.stringify(this.ticketItem_.getValue());
       for (var i = 0, option; option = select.options[i]; i++) {
         if (option.value == valueToSelect) {
           indexToSelect = i;
@@ skipping 23 matching lines @@
       this.updateSelect_();
       this.updateUiStateInternal();
     }
   };
 
   // Export
   return {
     MediaSizeSettings: MediaSizeSettings
   };
 });