Compile print_preview, part 3: reduce down to 185 errors

chrome/browser/resources/print_preview/print_preview.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(rltoscano): Move data/* into print_preview.data namespace
 
 var localStrings = new LocalStrings(templateData);
 
 <include src="component.js"/>
 <include src="print_preview_focus_manager.js"/>
@@ skipping 244 matching lines @@
 
     /**
      * Whether to show system dialog before next printing.
      * @type {boolean}
      * @private
      */
     this.showSystemDialogBeforeNextPrint_ = false;
   };
 
   /**
-   * States of the print preview.
-   * @enum {string}
-   * @private
-   */
-  PrintPreview.UiState_ = {
-    INITIALIZING: 'initializing',
-    READY: 'ready',
-    OPENING_PDF_PREVIEW: 'opening-pdf-preview',
-    OPENING_CLOUD_PRINT_DIALOG: 'opening-cloud-print-dialog',
-    OPENING_NATIVE_PRINT_DIALOG: 'opening-native-print-dialog',
-    PRINTING: 'printing',
-    FILE_SELECTION: 'file-selection',
-    CLOSING: 'closing',
-    ERROR: 'error'
-  };
-
-  /**
    * What can happen when print preview tries to print.
    * @enum {string}
    * @private
    */
   PrintPreview.PrintAttemptResult_ = {
     NOT_READY: 'not-ready',
     PRINTED: 'printed',
     READY_WAITING_FOR_PREVIEW: 'ready-waiting-for-preview'
   };
 
@@ skipping 542 matching lines @@
        var devicesUrl = 'chrome://devices/register?id=' + e.destination.id;
        this.nativeLayer_.startForceOpenNewTab(devicesUrl);
        this.destinationStore_.waitForRegister(e.destination.id);
      },
 
     /**
      * Consume escape key presses and ctrl + shift + p. Delegate everything else
      * to the preview area.
      * @param {KeyboardEvent} e The keyboard event.
      * @private
+     * @suppress {uselessCode}
+     * Current compiler preprocessor leaves all the code inside all the <if>s,
+     * so the compiler claims that code after first return is unreachable.
      */
     onKeyDown_: function(e) {
       // Escape key closes the dialog.
       if (e.keyCode == 27 && !e.shiftKey && !e.ctrlKey && !e.altKey &&
           !e.metaKey) {
         <if expr="toolkit_views">
         // On the toolkit_views environment, ESC key is handled by C++-side
         // instead of JS-side.
         return;
         </if>
@@ skipping 63 matching lines @@
       this.destinationStore_.startLoadPrivetDestinations();
     },
 
     /**
      * Called when the destination settings' change button is activated.
      * Displays the destination search component.
      * @private
      */
     onAdvancedOptionsButtonActivated_: function() {
       this.advancedSettings_.showForDestination(
-          this.destinationStore_.selectedDestination);
+          assert(this.destinationStore_.selectedDestination));
     },
 
     /**
      * Called when the destination search dispatches manage cloud destinations
      * event. Calls corresponding native layer method.
      * @private
      */
     onManageCloudDestinationsActivated_: function() {
       this.nativeLayer_.startManageCloudDestinations();
     },
@@ skipping 40 matching lines @@
         localStrings.getString('couldNotPrint'));
     },
 
     /**
      * Called when the print preview settings need to be changed for testing.
      * @param {Event} event Event object that contains the option that is to
      *     be changed and what to set that option.
      * @private
      */
     onManipulateSettingsForTest_: function(event) {
+      event.settings =
+          /** @type {print_preview.PreviewSettings} */(event.settings);
       if ('selectSaveAsPdfDestination' in event.settings) {
         this.saveAsPdfForTest_();  // No parameters.
       } else if ('layoutSettings' in event.settings) {
         this.setLayoutSettingsForTest_(event.settings.layoutSettings.portrait);
       } else if ('pageRange' in event.settings) {
         this.setPageRangeForTest_(event.settings.pageRange);
       } else if ('headersAndFooters' in event.settings) {
         this.setHeadersAndFootersForTest_(event.settings.headersAndFooters);
       } else if ('backgroundColorsAndImages' in event.settings) {
         this.setBackgroundColorsAndImagesForTest_(
@@ skipping 119 matching lines @@
      * Returns true if "Print using system dialog" link should be shown for
      * current destination.
      * @return {boolean} Returns true if link should be shown.
      */
     shouldShowSystemDialogLink_: function() {
       if (!this.isSystemDialogAvailable_)
         return false;
       if (!cr.isWindows)
         return true;
       var selectedDest = this.destinationStore_.selectedDestination;
-      return selectedDest &&
+      return !!selectedDest &&
              selectedDest.origin == print_preview.Destination.Origin.LOCAL &&
              selectedDest.id !=
                  print_preview.Destination.GooglePromotedId.SAVE_AS_PDF;
     },
 
     /**
      * Called when the open-cloud-print-dialog link is clicked. Opens the Google
      * Cloud Print web dialog.
      * @private
      */
     onCloudPrintDialogLinkClick_: function() {
       assert(this.uiState_ == PrintPreview.UiState_.READY,
              'Opening Google Cloud Print dialog when not in ready state: ' +
                  this.uiState_);
       setIsVisible(getRequiredElement('cloud-print-dialog-throbber'), true);
       this.setIsEnabled_(false);
       this.uiState_ = PrintPreview.UiState_.OPENING_CLOUD_PRINT_DIALOG;
       this.printIfReady_();
     },
 
     /**
      * Called when a print destination is selected. Shows/hides the "Print with
      * Cloud Print" link in the navbar.
      * @private
      */
     onDestinationSelect_: function() {
       var selectedDest = this.destinationStore_.selectedDestination;
       setIsVisible(
           getRequiredElement('cloud-print-dialog-link'),
-          selectedDest && !cr.isChromeOS && !selectedDest.isLocal);
+          !!selectedDest && !cr.isChromeOS && !selectedDest.isLocal);
       setIsVisible(
           getRequiredElement('system-dialog-link'),
           this.shouldShowSystemDialogLink_());
       if (selectedDest && this.isInKioskAutoPrintMode_) {
         this.onPrintButtonClick_();
       }
     },
 
     /**
      * Called when the destination store loads a group of destinations. Shows
      * a promo on Chrome OS if the user has no print destinations promoting
      * Google Cloud Print.
      * @private
      */
     onDestinationSearchDone_: function() {
       var isPromoVisible = cr.isChromeOS &&
           this.cloudPrintInterface_ &&
           this.userInfo_.activeUser &&
           !this.appState_.isGcpPromoDismissed &&

[Aleksey Shlyapnikov, 2014/09/22 22:00:40]

It should be:
    !this.destinationStore_.isLocalDestinationSearchInProgress &&	
    !this.destinationStore_.isCloudDestinationSearchInProgress &&

[Vitaly Pavlenko, 2014/09/22 22:33:11]

Done.

-          !this.destinationStore_.isLocalDestinationsSearchInProgress &&
-          !this.destinationStore_.isCloudDestinationsSearchInProgress &&
           this.destinationStore_.hasOnlyDefaultCloudDestinations();
       setIsVisible(this.getChildElement('#no-destinations-promo'),
                    isPromoVisible);
       if (isPromoVisible) {
         new print_preview.GcpPromoMetricsContext().record(
             print_preview.Metrics.GcpPromoBucket.PROMO_SHOWN);
       }
     },
 
     /**
@@ skipping 22 matching lines @@
       this.close_();
     }
   };
 
   // Export
   return {
     PrintPreview: PrintPreview
   };
 });
 
+/**
+ * States of the print preview.
+ * @enum {string}
+ * @private
+ */
+print_preview.PrintPreview.UiState_ = {
+  INITIALIZING: 'initializing',
+  READY: 'ready',
+  OPENING_PDF_PREVIEW: 'opening-pdf-preview',
+  OPENING_CLOUD_PRINT_DIALOG: 'opening-cloud-print-dialog',
+  OPENING_NATIVE_PRINT_DIALOG: 'opening-native-print-dialog',
+  PRINTING: 'printing',
+  FILE_SELECTION: 'file-selection',
+  CLOSING: 'closing',
+  ERROR: 'error'
+};
+
 // Pull in all other scripts in a single shot.
 <include src="common/overlay.js"/>
 <include src="common/search_box.js"/>
 <include src="common/search_bubble.js"/>
 
 <include src="data/page_number_set.js"/>
 <include src="data/destination.js"/>
 <include src="data/local_parsers.js"/>
 <include src="data/cloud_parsers.js"/>
 <include src="data/destination_store.js"/>
@@ skipping 56 matching lines @@
 <include src="search/cloud_destination_list.js"/>
 <include src="search/recent_destination_list.js"/>
 <include src="search/destination_list_item.js"/>
 <include src="search/destination_search.js"/>
 <include src="search/fedex_tos.js"/>
 
 window.addEventListener('DOMContentLoaded', function() {
   printPreview = new print_preview.PrintPreview();
   printPreview.initialize();
 });