Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/accessibility/AXRenderObject.h

Issue 588653003: Adding support for ARIA 1.1 role="none" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/accessibility/AXObject.cpp ('K') | « Source/core/accessibility/AXObject.cpp ('k') | Source/core/accessibility/AXRenderObject.cpp » ('j') | Source/core/accessibility/AXRenderObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/accessibility/AXRenderObject.h
diff --git a/Source/core/accessibility/AXRenderObject.h b/Source/core/accessibility/AXRenderObject.h
index b747e7f7cf49ec6983edeb5357c7c2624eed49dc..6ef871c8a0efb753490a275dd094815ba890d37c 100644
--- a/Source/core/accessibility/AXRenderObject.h
+++ b/Source/core/accessibility/AXRenderObject.h
@@ -129,8 +129,8 @@ protected:
virtual void ariaOwnsElements(AccessibilityChildrenVector&) const OVERRIDE;
virtual bool ariaHasPopup() const OVERRIDE;
- virtual bool ariaRoleHasPresentationalChildren() const OVERRIDE;
- virtual bool isPresentationalChildOfAriaRole() const OVERRIDE;
+ virtual bool ariaRoleHasNoneOrPresentationalChildren() const OVERRIDE;
+ virtual bool isNoneOrPresentationalChildOfAriaRole() const OVERRIDE;
shreeramk 2014/09/20 12:39:36 Same query as AXObject.h.
virtual bool shouldFocusActiveDescendant() const OVERRIDE;
virtual bool supportsARIADragging() const OVERRIDE;
virtual bool supportsARIADropping() const OVERRIDE;
@@ -226,7 +226,7 @@ private:
void ariaSelectedRows(AccessibilityChildrenVector&);
bool elementAttributeValue(const QualifiedName&) const;
- bool inheritsPresentationalRole() const;
+ bool inheritsNoneOrPresentationalRole() const;
shreeramk 2014/09/20 12:39:36 Should I go ahead with above modified function nam
LayoutRect computeElementRect() const;
VisibleSelection selection() const;
int indexForVisiblePosition(const VisiblePosition&) const;
« Source/core/accessibility/AXObject.cpp ('K') | « Source/core/accessibility/AXObject.cpp ('k') | Source/core/accessibility/AXRenderObject.cpp » ('j') | Source/core/accessibility/AXRenderObject.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698